Add pagination helpers to PageRequest and javadoc to FilterResponse#1088
Add pagination helpers to PageRequest and javadoc to FilterResponse#1088
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
bdemers
force-pushed
the
feature/pagination-helpers
branch
from
36d37cb to
49da5d1
Compare
|
View details about the 'Apache Rat - Check' build 869 in the Build Scan 📊 |
|
View details about the 'Maven Verify (with Java 21-zulu)' build 1865 in the Build Scan 📊 |
|
View details about the 'Maven Verify (with Java 17-zulu)' build 1865 in the Build Scan 📊 |
|
View details about the 'Apache Rat - Check' build 870 in the Build Scan 📊 |
|
View details about the 'Maven Verify (with Java 21-zulu)' build 1866 in the Build Scan 📊 |
|
View details about the 'Maven Verify (with Java 17-zulu)' build 1866 in the Build Scan 📊 |
Add PageRequest.paginate(List) to apply offset/limit as a page slice, and ScimRequestContext.getPageRequestOrDefault() to avoid null-checking. Refactor all InMemory*Service.find() to filter BEFORE paginating, fixing a bug where skip/limit was applied before the filter predicate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bdemers
force-pushed
the
feature/pagination-helpers
branch
from
8cf354c to
389deae
Compare
|
View details about the 'Apache Rat - Check' build 872 in the Build Scan 📊 |
|
View details about the 'Apache Rat - Check' build 871 in the Build Scan 📊 |
|
View details about the 'Maven Verify (with Java 17-zulu)' build 1868 in the Build Scan 📊 |
|
View details about the 'Maven Verify (with Java 17-zulu)' build 1867 in the Build Scan 📊 |
|
View details about the 'Maven Verify (with Java 21-zulu)' build 1868 in the Build Scan 📊 |
|
View details about the 'Maven Verify (with Java 21-zulu)' build 1867 in the Build Scan 📊 |
1 participant
PageRequest gains getZeroBasedStartIndex() and getEffectiveCount(int)
to eliminate the error-prone 1-based to 0-based conversion that every
Repository implementation must duplicate.
FilterResponse gets javadoc clarifying that totalResults must be the
total count of ALL matching resources before pagination, not the page
size. References RFC 7644 §3.4.2.4.
Generated-by: Claude Opus 4.6 (1M context) noreply@anthropic.com