Skip to content

Add FilterExpressionVisitor SPI with accept() on FilterExpression#1090

Merged
bdemers merged 1 commit intodevelopfrom
feature/filter-visitor-spi
Apr 3, 2026
Merged

Add FilterExpressionVisitor SPI with accept() on FilterExpression#1090
bdemers merged 1 commit intodevelopfrom
feature/filter-visitor-spi

Conversation

@bdemers
Copy link
Copy Markdown
Member

@bdemers bdemers commented Mar 30, 2026

Introduces a visitor interface for traversing the sealed FilterExpression
hierarchy. Since FilterExpression permits exactly 5 subtypes, visitor
implementations are compile-time complete — all expression types must
be handled.

Adds accept(FilterExpressionVisitor) default method on
FilterExpression that dispatches to the appropriate visit() method.
This replaces the instanceof chain pattern needed by non-in-memory
backends (LDAP, SQL, etc.) for filter-to-query translation.

@bdemers
Copy link
Copy Markdown
Member Author

bdemers commented Mar 30, 2026

This change is part of the following stack:

Change managed by git-spice.

@bdemers bdemers force-pushed the feature/attribute-normalization branch from 1b4dea5 to 18989d9 Compare March 30, 2026 22:03
@bdemers bdemers force-pushed the feature/filter-visitor-spi branch from cc24f85 to 7012a44 Compare March 30, 2026 22:03
@bdemers bdemers force-pushed the feature/attribute-normalization branch from 18989d9 to 9b66a1f Compare April 3, 2026 01:48
@bdemers bdemers force-pushed the feature/filter-visitor-spi branch from 7012a44 to 1a836c0 Compare April 3, 2026 01:48
@bdemers bdemers force-pushed the feature/attribute-normalization branch from 9b66a1f to 8bc0072 Compare April 3, 2026 02:06
@bdemers bdemers force-pushed the feature/filter-visitor-spi branch from 1a836c0 to 11ea545 Compare April 3, 2026 02:06
@bdemers bdemers force-pushed the feature/attribute-normalization branch from 8bc0072 to 29e77ba Compare April 3, 2026 02:33
@bdemers bdemers force-pushed the feature/filter-visitor-spi branch from 11ea545 to f94b4fd Compare April 3, 2026 02:33
Base automatically changed from feature/attribute-normalization to develop April 3, 2026 02:39
@bdemers bdemers force-pushed the feature/filter-visitor-spi branch from f94b4fd to 45f1a2b Compare April 3, 2026 02:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Apache Rat - Check' build 878 in the Build Scan 📊

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Apache Rat - Check' build 879 in the Build Scan 📊

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Maven Verify (with Java 21-zulu)' build 1871 in the Build Scan 📊

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Maven Verify (with Java 17-zulu)' build 1871 in the Build Scan 📊

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Maven Verify (with Java 17-zulu)' build 1872 in the Build Scan 📊

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Maven Verify (with Java 21-zulu)' build 1872 in the Build Scan 📊

Introduces a visitor interface for traversing the sealed FilterExpression
hierarchy. Since FilterExpression permits exactly 5 subtypes, visitor
implementations are compile-time complete — all expression types must
be handled.

Adds accept(FilterExpressionVisitor<R>) default method on
FilterExpression that dispatches to the appropriate visit() method.
This replaces the instanceof chain pattern needed by non-in-memory
backends (LDAP, SQL, etc.) for filter-to-query translation.

Generated-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bdemers bdemers force-pushed the feature/filter-visitor-spi branch from 3c47390 to 4b4c812 Compare April 3, 2026 21:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Apache Rat - Check' build 885 in the Build Scan 📊

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Maven Verify (with Java 17-zulu)' build 1876 in the Build Scan 📊

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

View details about the 'Maven Verify (with Java 21-zulu)' build 1876 in the Build Scan 📊

@bdemers bdemers merged commit e26e194 into develop Apr 3, 2026
6 checks passed
@bdemers bdemers deleted the feature/filter-visitor-spi branch April 3, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant