Repository navigation
refactor(pagebroker): organize transfer engines and filesystem helpers - #432
Merged
tzachi-runai merged 0 commit intoOct 1, 2026
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 1, 2026
tzachi-runai
force-pushed
the
dyn-4108/pagebroker-transfer-layout
branch
from
October 1, 2026 08:39
2848452 to
a22397e
Compare
tzachi-runai
force-pushed
the
dyn-4108/model-streamer-transfer-config
branch
from
October 1, 2026 08:39
f400a5e to
7bb049a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #434, which contains the original layout-only change after #265. This PR was automatically marked merged during a temporary branch reorder; the original branch contents have since been restored.
What type of PR is this?
What this PR does / why we need it:
Move existing PageBroker transfer files into directories for the engine interface, POSIX engine, ModelStreamer engine, and filesystem helpers. Separating these moves from #383 lets reviewers read the S3 feature changes at stable paths.
transfer/engine/,transfer/engine/posix/,transfer/engine/model_streamer/, andtransfer/filesystem/.Which issue(s) this PR fixes:
Part of #237.
How was this tested?
make check test buildpassed.The host skips CUDA helper tests because OpenSSL development files are unavailable.
Special notes for your reviewer:
Stacked on #265; #383 will use this branch as its base, followed by #410 and #416. This PR contains only file moves and the include/build paths needed to keep the existing code working. The feature branches retain their existing history and file contents.
Does this PR introduce an API change?
Additional documentation, e.g. enhancement proposals, usage docs:
Checklist
git commit -s).make check test buildpasses locally.