Skip to content

refactor(pagebroker): organize transfer engines and filesystem helpers - #432

Merged
tzachi-runai merged 0 commit into
dyn-4108/model-streamer-transfer-configfrom
dyn-4108/pagebroker-transfer-layout
Oct 1, 2026
Merged

tzachi-runai merged 0 commit into
dyn-4108/model-streamer-transfer-configfrom
dyn-4108/pagebroker-transfer-layout

Conversation

@tzachi-runai

@tzachi-runai tzachi-runai commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Superseded by #434, which contains the original layout-only change after #265. This PR was automatically marked merged during a temporary branch reorder; the original branch contents have since been restored.

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Move existing PageBroker transfer files into directories for the engine interface, POSIX engine, ModelStreamer engine, and filesystem helpers. Separating these moves from #383 lets reviewers read the S3 feature changes at stable paths.

  • Move 12 existing files into transfer/engine/, transfer/engine/posix/, transfer/engine/model_streamer/, and transfer/filesystem/.
  • Update 13 include/build path lines to match. File contents are otherwise unchanged, and no empty directories or new feature files are introduced.
  • Keep API changes, transaction refactoring, header consolidation, and S3 functionality in feat(pagebroker): package and test native S3 reads #383 and its descendants.

Which issue(s) this PR fixes:

Part of #237.

How was this tested?

The host skips CUDA helper tests because OpenSSL development files are unavailable.

Special notes for your reviewer:

Stacked on #265; #383 will use this branch as its base, followed by #410 and #416. This PR contains only file moves and the include/build paths needed to keep the existing code working. The feature branches retain their existing history and file contents.

Does this PR introduce an API change?

NONE

Additional documentation, e.g. enhancement proposals, usage docs:

NONE

Checklist

  • Commits are signed off (git commit -s).
  • make check test build passes locally.
  • Documentation reviewed; runtime behavior is unchanged.

@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant