Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions scripts/release-please-dry-run/open-pr.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,18 @@ export function narrow(config, manifest, tagExists) {
return { config: { ...config, packages }, waiting };
}

/**
* The release branches whose merged pull requests release-please never tags: a package
* with skip-github-release gets its tag from the factory's cut (release-cut.yml), so its
* merged pull request keeps the label `autorelease: pending` for good. Left in, it would
* make release-please refuse every other package's release pull request.
*/
export function factoryCutBranches(config, targetBranch) {
return Object.values(config.packages)
.filter((settings) => settings['skip-github-release'] ?? config['skip-github-release'])
.map((settings) => `release-please--branches--${targetBranch}--components--${settings.component}`);
}

async function main() {
const { values } = parseArgs({ options: {
repo: { type: 'string', default: process.env.GITHUB_REPOSITORY || 'UOR-Foundation/prismpm' },
Expand Down Expand Up @@ -78,7 +90,18 @@ async function main() {
return { sha: '', mode: '100644', branch, parsedContent, content: Buffer.from(parsedContent).toString('base64') };
};
const manifest = await Manifest.fromManifest(github, values.branch, CONFIG, MANIFEST);
const factoryCut = new Set(factoryCutBranches(read(CONFIG), values.branch));
const merged = manifest.findMergedReleasePullRequests.bind(manifest);
manifest.findMergedReleasePullRequests = async function* () {
for await (const pr of merged()) if (!factoryCut.has(pr.headBranchName)) yield pr;
};
// release-please returns no pull request, with only a log line, when it refuses; a
// refusal must fail the run instead of reading as nothing to release.
const build = manifest.buildPullRequests.bind(manifest);
let built = 0;
manifest.buildPullRequests = async () => { const candidates = await build(); built = candidates.length; return candidates; };
const prs = (await manifest.createPullRequests()).filter(Boolean);
if (built > prs.length) throw new Error(`release-please built ${built} release pull requests and opened ${prs.length}: read its warnings above`);
for (const pr of prs) console.log(`release pull request #${pr.number} from ${pr.headBranchName}`);
if (process.env.GITHUB_OUTPUT) {
appendFileSync(process.env.GITHUB_OUTPUT, `prs_created=${prs.length > 0}\nprs=${JSON.stringify(prs)}\n`);
Expand Down
7 changes: 6 additions & 1 deletion sdk/docs/test/release-config.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { join } from 'node:path';
import { HEADERS } from '../lib/changelog.mjs';
import { ROOT } from '../lib/spec.mjs';
import { releasedPackages } from '../../../scripts/release-please-notes.mjs';
import { GUARDED, narrow, tagOf } from '../../../scripts/release-please-dry-run/open-pr.mjs';
import { GUARDED, factoryCutBranches, narrow, tagOf } from '../../../scripts/release-please-dry-run/open-pr.mjs';

const read = (path) => readFileSync(join(ROOT, path), 'utf8').split('\r\n').join('\n');
const config = JSON.parse(read('release-please-config.json'));
Expand Down Expand Up @@ -117,6 +117,11 @@ test('a package whose version is untagged waits alone, and the others still get
assert.throws(() => narrow({ ...config, packages: { '.': config.packages['.'] } }, manifest, () => false), /every one waits/);
});

test('a merged release pull request of a package the factory tags never blocks the others', () => {
assert.deepEqual(factoryCutBranches(config, 'main'), ['release-please--branches--main--components--prismpm']);
assert.deepEqual(factoryCutBranches({ packages: { 'sdk/npm/prism-code': config.packages['sdk/npm/prism-code'] } }, 'main'), []);
});

test('the dry run can only read', () => {
const dryRun = uncommented(job('dry-run'));
assert.match(dryRun, /contents: read/);
Expand Down
Loading