Skip to content

fix(release): the root's merged release pull request no longer blocks prism-code's - #710

Merged
humuhumu33 merged 1 commit into
mainfrom
fix/release-pr-factory-cut
Nov 16, 2026
Merged

humuhumu33 merged 1 commit into
mainfrom
fix/release-pr-factory-cut

Conversation

@humuhumu33

Copy link
Copy Markdown
Contributor

Why

After #708, open-pr (run 43962800582) finished green but opened nothing. Its log said Found pull request #661: 'chore(main): release 0.5.0' and then There are untagged, merged release PRs outstanding - aborting. release-please refuses every package while any merged release pull request still has the label autorelease: pending. The root package has skip-github-release, so the factory cut tags it and release-please never relabels #661. Left as is, it would block every release, even after v0.5.0 exists.

The probe in #708 called buildPullRequests, which skips this check, so it missed this.

How

  • open-pr.mjs ignores merged release pull requests on the branch of any package with skip-github-release. That is release-please--branches--main--components--prismpm, taken from the config, not hardcoded.
  • The run now fails when release-please built more release pull requests than it opened, so a refusal can no longer pass as "nothing to release".

What was checked

  • node --test sdk/docs/test/release-config.test.mjs: 17 pass, one of them new.
  • Planted defect: factoryCutBranches returning [] fails the new test, and restoring it passes.
  • Read-only live run against main, this time also through the merged-PR check: nothing blocks, and it would open prism-code 0.9.5, spec 0.2.0, verify 0.2.0, conformance 0.2.0 and testing 0.1.1.

🤖 Generated with Claude Code

… prism-code's

After #708, open-pr ran green and opened nothing. release-please refuses
every release pull request while any merged one is still labelled
`autorelease: pending`, and the root's (#661) stays so for good: the root
has skip-github-release, so the factory cut tags it and release-please
never relabels it.

open-pr now ignores merged release pull requests on the branch of a
package with skip-github-release, and fails when release-please built
release pull requests but opened fewer, so a refusal cannot pass as
nothing to release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@humuhumu33
humuhumu33 merged commit 46c4146 into main Nov 16, 2026
6 checks passed
@humuhumu33
humuhumu33 deleted the fix/release-pr-factory-cut branch November 16, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant