Repository navigation
fix(release): the root's merged release pull request no longer blocks prism-code's - #710
Merged
Merged
Conversation
… prism-code's After #708, open-pr ran green and opened nothing. release-please refuses every release pull request while any merged one is still labelled `autorelease: pending`, and the root's (#661) stays so for good: the root has skip-github-release, so the factory cut tags it and release-please never relabels it. open-pr now ignores merged release pull requests on the branch of a package with skip-github-release, and fails when release-please built release pull requests but opened fewer, so a refusal cannot pass as nothing to release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #708,
open-pr(run 43962800582) finished green but opened nothing. Its log saidFound pull request #661: 'chore(main): release 0.5.0'and thenThere are untagged, merged release PRs outstanding - aborting. release-please refuses every package while any merged release pull request still has the labelautorelease: pending. The root package hasskip-github-release, so the factory cut tags it and release-please never relabels #661. Left as is, it would block every release, even afterv0.5.0exists.The probe in #708 called
buildPullRequests, which skips this check, so it missed this.How
open-pr.mjsignores merged release pull requests on the branch of any package withskip-github-release. That isrelease-please--branches--main--components--prismpm, taken from the config, not hardcoded.What was checked
node --test sdk/docs/test/release-config.test.mjs: 17 pass, one of them new.factoryCutBranchesreturning[]fails the new test, and restoring it passes.main, this time also through the merged-PR check: nothing blocks, and it would open prism-code 0.9.5, spec 0.2.0, verify 0.2.0, conformance 0.2.0 and testing 0.1.1.🤖 Generated with Claude Code