Skip to content

fix(release): a package whose version is untagged waits alone, so prism-code releases without v0.5.0 - #708

Merged
humuhumu33 merged 1 commit into
mainfrom
fix/release-pr-per-package-tag
Nov 16, 2026
Merged

humuhumu33 merged 1 commit into
mainfrom
fix/release-pr-per-package-tag

Conversation

@humuhumu33

Copy link
Copy Markdown
Contributor

Why

release-please mode open-pr refused every release pull request while either v<root> or prism-code-v<version> was missing. The manifest says 0.5.0 (#661), but v0.5.0 is the factory's cut (release-cut.yml), which waits on a passing rehearsal. Run 43941312852 failed with tag v0.5.0 does not exist, and prism-code 0.9.2 to 0.9.4 were opened by hand on the release-please branch.

How

A package whose current version has no tag now waits alone; the rest still get release pull requests. The pinned action reads its config from the branch and cannot leave one package out, so open-pr runs scripts/release-please-dry-run/open-pr.mjs: the same release-please library (17.1.3, already locked for the dry run, the version action v4.4.0 bundles) with the config narrowed in memory. It writes prs and prs_created in the action's shape, so the finishing step is unchanged. The config file is never edited.

What was checked

  • node --test sdk/docs/test/release-config.test.mjs: 16 pass. A new test covers root waiting, both tagged, and nothing releasable.
  • Planted defect: narrow keeping every package fails that test, and restoring it passes.
  • Read-only live run against main (buildPullRequests instead of createPullRequests): it warns that . waits on v0.5.0 and would open prism-code 0.9.5, plus spec 0.2.0, verify 0.2.0, conformance 0.2.0 and testing 0.1.1.
  • sdk/docs/test/*: one existing failure ("a broken narrative page fails the build") also fails on main and is unrelated.

Not done: no open-pr dispatch yet. That writes pull requests, so it waits for this merge.

🤖 Generated with Claude Code

…sm-code releases without v0.5.0

open-pr refused every release pull request while any guarded tag was
missing. The root tag v0.5.0 is the factory's cut and has not happened, so
prism-code release pull requests have been opened by hand since 0.9.1.

The guard now drops only the untagged package. release-please-action reads
its config from the branch and cannot leave one package out, so open-pr runs
the same release-please library (17.1.3, the version the pinned action
bundles) with the config narrowed in memory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@humuhumu33
humuhumu33 merged commit 1a36a18 into main Nov 16, 2026
5 of 6 checks passed
@humuhumu33
humuhumu33 deleted the fix/release-pr-per-package-tag branch November 16, 2026 21:42
humuhumu33 added a commit that referenced this pull request Nov 16, 2026
… prism-code's (#710)

After #708, open-pr ran green and opened nothing. release-please refuses
every release pull request while any merged one is still labelled
`autorelease: pending`, and the root's (#661) stays so for good: the root
has skip-github-release, so the factory cut tags it and release-please
never relabels it.

open-pr now ignores merged release pull requests on the branch of a
package with skip-github-release, and fails when release-please built
release pull requests but opened fewer, so a refusal cannot pass as
nothing to release.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant