Repository navigation
fix(release): a package whose version is untagged waits alone, so prism-code releases without v0.5.0 - #708
Merged
Conversation
…sm-code releases without v0.5.0 open-pr refused every release pull request while any guarded tag was missing. The root tag v0.5.0 is the factory's cut and has not happened, so prism-code release pull requests have been opened by hand since 0.9.1. The guard now drops only the untagged package. release-please-action reads its config from the branch and cannot leave one package out, so open-pr runs the same release-please library (17.1.3, the version the pinned action bundles) with the config narrowed in memory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
humuhumu33
added a commit
that referenced
this pull request
Nov 16, 2026
… prism-code's (#710) After #708, open-pr ran green and opened nothing. release-please refuses every release pull request while any merged one is still labelled `autorelease: pending`, and the root's (#661) stays so for good: the root has skip-github-release, so the factory cut tags it and release-please never relabels it. open-pr now ignores merged release pull requests on the branch of a package with skip-github-release, and fails when release-please built release pull requests but opened fewer, so a refusal cannot pass as nothing to release. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
release-pleasemodeopen-prrefused every release pull request while eitherv<root>orprism-code-v<version>was missing. The manifest says0.5.0(#661), butv0.5.0is the factory's cut (release-cut.yml), which waits on a passing rehearsal. Run 43941312852 failed withtag v0.5.0 does not exist, and prism-code 0.9.2 to 0.9.4 were opened by hand on the release-please branch.How
A package whose current version has no tag now waits alone; the rest still get release pull requests. The pinned action reads its config from the branch and cannot leave one package out, so
open-prrunsscripts/release-please-dry-run/open-pr.mjs: the samerelease-pleaselibrary (17.1.3, already locked for the dry run, the version action v4.4.0 bundles) with the config narrowed in memory. It writesprsandprs_createdin the action's shape, so the finishing step is unchanged. The config file is never edited.What was checked
node --test sdk/docs/test/release-config.test.mjs: 16 pass. A new test covers root waiting, both tagged, and nothing releasable.narrowkeeping every package fails that test, and restoring it passes.main(buildPullRequestsinstead ofcreatePullRequests): it warns that.waits onv0.5.0and would open prism-code 0.9.5, plus spec 0.2.0, verify 0.2.0, conformance 0.2.0 and testing 0.1.1.sdk/docs/test/*: one existing failure ("a broken narrative page fails the build") also fails onmainand is unrelated.Not done: no
open-prdispatch yet. That writes pull requests, so it waits for this merge.🤖 Generated with Claude Code