Repository navigation
feat(prism-code): trust decisions in verify, signing in auth (Part of #449) - #623
Merged
Merged
Conversation
…449) - verify-closure.mjs (verify) makes every trust decision push and pull need: the claims about the pulled bytes, the attestation subjects, the verdict and the signer policy, and push's outgoing integrity check. push-pull.mjs only fetches and writes. prism.verify.pullClosure exposes it. - signing.mjs (auth) holds the Sigstore signing code that was in attest.mjs. Every signature goes through an auth identity; auth.identities.from turns the flat signer options into one. attest-write.mjs (images) writes signed statements; attest.mjs keeps only verification. - model/modules.toml: owners for the three files, and the pending "Signing parts of attest move to auth" cut is made. - runtimes.json registers the Rust shim (DK-42); the npm conformance suite job builds and runs it, and COMPLIANCE.md shows Rust and JavaScript both passing all 24 verify checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3Mf94yL5KHxQf3uUBS
…rt of #449) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3Mf94yL5KHxQf3uUBS
…lowance covers 9.7 KiB (Part of #449) The suite job builds prism-conformance-shim only when no main push has measured the same content identity (git blob ids of the Rust sources, vendored crates, lockfile, toolchain pin, the suite and this workflow). Only receipts from this repository's main pushes are trusted. The matrix unit tests read that receipt or the built shim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3Mf94yL5KHxQf3uUBS
Member
Author
|
The npm-prism-code jobs fail on one test only: Generated by Claude Code |
# Conflicts: # sdk/npm/prism-code/CHANGELOG.md
afflom
added a commit
that referenced
this pull request
Nov 12, 2026
…y and reference syntax (Part of #448) (#626) Each contract's semantic check runs in its owner module; CanonicalDocument refuses the 19 owner-checked ids unless the owner's check runs. encode/decode_canonical move to holo/model_document.rs, SDK advisory disposition to sdk/advisory.rs (verify), OCI reference syntax to reference.rs (verify). check-modules: 15 -> 2 pending (with #623), contracts and workbench leave the legacy cycle. Emitter digest, ct-02/tm-01 bindings, standards.lock, generator pin, stdlib goldens (run 43167050013) and native records (run 43171961132) move with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
This was referenced Nov 12, 2026
Merged
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Alex · project thread
Part of #449 (prism.verify) and the signing cut of #447 (prism.auth). This is v0.5 workstream WS5.
Why
#449's done-when says every trust decision about an image is made in
verifyand nowhere else, and thatpullgets its answer only from there. On main,push-pull.mjs(owned byimages) made those decisions itself:verifyHolo,judge,checkAttestations,aboutThisHoloandcheckSigner. Signing was the other half of the problem.model/modules.tomlstill listed the pending cut "Signing parts of attest move to auth", andpush-pull.mjsandattest.mjscalledsignStatementdirectly.What
src/verify-closure.mjs(verify) now holds steps 4 to 8 of the push/pull design: the BLAKE3 claims, the attestation subjects, the verdict under policy, and the signer policy over in-holo and referrer bundles. It also holds push's step 1 integrity check (verifyOutgoing).imagespasses it plain facts (the bytes, the manifest digest, the annotation claims, the asked fingerprint, the referrer lines) and gets back a verdict or a typed refusal. The checks, error classes andcheckids are the same as before.prism.verify.pullClosureexposes it, and it is loaded lazily, so the namespace stays browser-safe at load.src/push-pull.mjsonly fetches and writes now.src/signing.mjs(auth) holds the Sigstore signing code that was inattest.mjs, and it depends only onerrors.auth.identities.from(options)turns the flat signer options into an identity.attest,signStatementsandpushall sign through it, so every signature gets auth's secret scrubbing. A keyless failure that happens before any token was read keeps itscause, as it did before.src/attest-write.mjs(images) holdsexperimental_attestandexperimental_signStatements. They build statements over the holo's blobs and sign them with an auth identity. Both are still exported unchanged fromprism-code/node.attest.mjskeeps only verification.model/modules.tomlgets owners for the three new files, and the pending auth→attest row is removed.cargo xtask check-modulesreports 14 pending, down from 15.sdk/npm/conformance/runtimes.jsonregisters the Rust shim (prism-conformance-shim, DK-42). The npm-conformancesuitejob builds it once (cargo build --locked -p repo-conformance --bin prism-conformance-shim), runs the matrix unit tests and both runtimes, and checksCOMPLIANCE.md. The regenerated matrix shows Rust and JavaScript both passing all 24verifychecks. Rust is 64 pass and 76 declared xfail; JS is 140 of 140. The three unit tests that run every registered runtime skip on the OS matrix, with a message saying why. They run in the suite job, so no runner is added.Merge order
This PR needs #618 (the package allowance ledger). Until #618 merges,
package.test.mjsfails on the cap. I'll rebase onto main once #618 lands.Test
npm testin sdk/npm/prism-code: 854 pass. The 2 failures are the cap (waiting on ci(prism-code): sum the package cap from one allowance file per change (Part of #441) #618) andreference-archives.test.mjs, which fails locally on main too.node --test test/*.test.mjsin sdk/npm/conformance: 86/86 with the shim built, and 83 pass + 3 skipped without it.prism-conformance matrix --results … --checkpasses.cargo xtask check-modulespasses.Generated by Claude Code