Repository navigation
refactor(prismpm): process helpers move to verify, the last pending module cut (Part of #448) - #628
Merged
Merged
Conversation
…yntax to their module owners (Part of #448) Each contract's semantic check now runs in the module that owns its meaning. CanonicalDocument keeps the schema table and closed-shape checks in errors and refuses an owner-checked id unless the owner's own check is supplied, so no caller can hold a document whose checks did not run. - contracts.rs: OWNER_CHECKED table, parse_owned/from_value_owned; owner checks in sdk, acceptance, oci, library_build, library_verification and the new model_contract; contract_owners routes by id. - holo/canonical.rs keeps the value codec; encode_canonical and decode_canonical move to holo/model_document.rs. - SDK advisory disposition moves from supply_chain to sdk/advisory.rs (verify); OCI reference syntax moves from oci to reference.rs (verify). - modules.toml: 15 -> 3 pending, contracts and workbench leave the legacy cycle. Emitter digest and ct-02/tm-01 model digest rebound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…format gate (Part of #448) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…per digest (Part of #448) authority.rs is the hashed wrapper source of six oracles, and the reference syntax import changed it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…s id (Part of #448) Applied from golden-refresh run 43167050013 for 5c8631c. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…oller import change (Part of #448) controller/mod.rs now imports encode_canonical from holo::model_document; the pin is the sha256 of the formatted file (e95ddbac). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…(Part of #448) From native-source-review run 43171961132 on 5e83583. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…odule cut (Part of #448) ProcessRecord, executable(s), run_process* and the pinned launcher digests move from verification.rs (images) to sdk/process.rs (verify). The record is generic over the caller's extension: verify callers use NoExtension, and verification::ProcessRecord keeps the exporter custody record, with thin wrappers so no images caller changes. check-modules: 0 pending; authority and browser_oracle leave the legacy cycle (17 -> 15). The tools.lock pin audit and SE-03/SE-04 now read sdk/process.rs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Alex · project thread
Part of #448 and #449, Rust side. This is the follow-up to #626 and the last of WS6.
Why
After #626 and #623,
model/modules.tomlstill held two pending forbidden edges:replay/mod.rs→verification.rsandsdk.rs→verification.rs("Process helpers move to verify"). The reason was thatProcessRecordcarriedexporter: Option<crate::exporter::ExporterExecution>, animagestype, so the process helpers could not live inverify.What
sdk/process.rs(verify) now holdsProcessRecord,executable/executables,run_process,run_process_limited,run_process_limited_allowed,progress, the output limit and timeout, and the pinned launcher digests. It lives undersdk/becauseexecutablereads the SDK inventory, and putting it insidesdkkeeps the two from forming a new cycle.ProcessRecord<X = NoExtension>is generic over its caller's extension record. Verify callers (replay,sdk) useNoExtension, an empty enum, so they cannot attach anything.verification::ProcessRecordis the alias with the exporter's custody record, andverification::run_process*are thin wrappers. Noimagescaller changes, and no emitter input or pinned file is touched (controller/mod.rs,application_build.rsandauthority.rsare unchanged).tools.locklauncher-pin audit (xtask) and the SE-03/SE-04 conformance source checks now readsdk/process.rs, whereCommand::new,env_clear,LC_ALL,LANGand the pins now live.cargo xtask check-modulesreports 0 pending, andauthorityandbrowser_oracleleavelegacy_cycle(17 → 15). The 15 that remain are all inimages, which is the outcome the proposal describes.Test
cargo clippy -p prismpm -p repo-conformance -p xtask --all-targets -- -D warningsis clean, andcargo fmtis clean.check-modulesandvalidate-modelpass.conformance_se_03andconformance_se_04pass.vr_09andvr_10needlake, which this container doesn't have.sdk/metadata-embedded.test.mjs, which readssdk.rs, passes.The branch carries one
-s oursmerge of its earlier, squash-merged #626 history. It changes no content and only exists so the push could fast-forward. Squash-merging this PR drops it.Generated by Claude Code