Skip to content

refactor(prismpm): process helpers move to verify, the last pending module cut (Part of #448) - #628

Merged
afflom merged 9 commits into
mainfrom
claude/project-thread-h6sbjv
Nov 12, 2026
Merged

afflom merged 9 commits into
mainfrom
claude/project-thread-h6sbjv

Conversation

@afflom

@afflom afflom commented Nov 12, 2026

Copy link
Copy Markdown
Member

Requested by Alex · project thread

Part of #448 and #449, Rust side. This is the follow-up to #626 and the last of WS6.

Why

After #626 and #623, model/modules.toml still held two pending forbidden edges: replay/mod.rs → verification.rs and sdk.rs → verification.rs ("Process helpers move to verify"). The reason was that ProcessRecord carried exporter: Option<crate::exporter::ExporterExecution>, an images type, so the process helpers could not live in verify.

What

  • sdk/process.rs (verify) now holds ProcessRecord, executable/executables, run_process, run_process_limited, run_process_limited_allowed, progress, the output limit and timeout, and the pinned launcher digests. It lives under sdk/ because executable reads the SDK inventory, and putting it inside sdk keeps the two from forming a new cycle.
  • ProcessRecord<X = NoExtension> is generic over its caller's extension record. Verify callers (replay, sdk) use NoExtension, an empty enum, so they cannot attach anything. verification::ProcessRecord is the alias with the exporter's custody record, and verification::run_process* are thin wrappers. No images caller changes, and no emitter input or pinned file is touched (controller/mod.rs, application_build.rs and authority.rs are unchanged).
  • The tools.lock launcher-pin audit (xtask) and the SE-03/SE-04 conformance source checks now read sdk/process.rs, where Command::new, env_clear, LC_ALL, LANG and the pins now live.
  • Module gate. cargo xtask check-modules reports 0 pending, and authority and browser_oracle leave legacy_cycle (17 → 15). The 15 that remain are all in images, which is the outcome the proposal describes.

Test

  • cargo clippy -p prismpm -p repo-conformance -p xtask --all-targets -- -D warnings is clean, and cargo fmt is clean.
  • check-modules and validate-model pass. conformance_se_03 and conformance_se_04 pass. vr_09 and vr_10 need lake, which this container doesn't have.
  • sdk/metadata-embedded.test.mjs, which reads sdk.rs, passes.

The branch carries one -s ours merge of its earlier, squash-merged #626 history. It changes no content and only exists so the push could fast-forward. Squash-merging this PR drops it.


Generated by Claude Code

…yntax to their module owners (Part of #448)

Each contract's semantic check now runs in the module that owns its
meaning. CanonicalDocument keeps the schema table and closed-shape checks
in errors and refuses an owner-checked id unless the owner's own check is
supplied, so no caller can hold a document whose checks did not run.

- contracts.rs: OWNER_CHECKED table, parse_owned/from_value_owned; owner
  checks in sdk, acceptance, oci, library_build, library_verification and
  the new model_contract; contract_owners routes by id.
- holo/canonical.rs keeps the value codec; encode_canonical and
  decode_canonical move to holo/model_document.rs.
- SDK advisory disposition moves from supply_chain to sdk/advisory.rs
  (verify); OCI reference syntax moves from oci to reference.rs (verify).
- modules.toml: 15 -> 3 pending, contracts and workbench leave the
  legacy cycle. Emitter digest and ct-02/tm-01 model digest rebound.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…format gate (Part of #448)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…per digest (Part of #448)

authority.rs is the hashed wrapper source of six oracles, and the reference
syntax import changed it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…s id (Part of #448)

Applied from golden-refresh run 43167050013 for 5c8631c.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…oller import change (Part of #448)

controller/mod.rs now imports encode_canonical from holo::model_document;
the pin is the sha256 of the formatted file (e95ddbac).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…(Part of #448)

From native-source-review run 43171961132 on 5e83583.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
…odule cut (Part of #448)

ProcessRecord, executable(s), run_process* and the pinned launcher digests
move from verification.rs (images) to sdk/process.rs (verify). The record is
generic over the caller's extension: verify callers use NoExtension, and
verification::ProcessRecord keeps the exporter custody record, with thin
wrappers so no images caller changes. check-modules: 0 pending; authority
and browser_oracle leave the legacy cycle (17 -> 15). The tools.lock pin
audit and SE-03/SE-04 now read sdk/process.rs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Asa3PtscX6WjMRzTzT3xZ
@afflom
afflom merged commit dd2cf14 into main Nov 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants