Repository navigation
ci(prism-code): sum the package cap from one allowance file per change (Part of #441) - #618
Merged
Merged
Conversation
PACKAGE_LIMIT was one comment line that every change growing the package edited, so parallel v0.5 PRs would all conflict on it. The cap is now the sum of scripts/package-allowances/*.json, each holding a kib and a reason. The 19 allowances on the old line move over unchanged (1584 KiB in total, the same 1622016 bytes), and the package test reads the limit instead of repeating the number. Part of #441 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3QVSkS6PGopegNeztG
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Alex · project thread
Why
Every change that grows the
prism-codepackage edited the singlePACKAGE_LIMITcomment line inscripts/check-package.mjs. Five v0.5 workstreams (#441-#449) are now running in parallel, and all of them would conflict on that one line. Main has about 2.6 KiB of headroom, so each of them needs an allowance.What
PACKAGE_LIMITis now the sum ofsdk/npm/prism-code/scripts/package-allowances/*.json. Each file holds exactly{ "kib": n, "reason": "..." }, and malformed files are refused.test/package.test.mjsreads the limit instead of repeating1622016/1584 KiB.A change that needs room adds its own file, so parallel PRs never touch the same line. #614's +8 KiB becomes one more file when it rebases.
Test
node --test test/package.test.mjs(with npm_execpath set): 4/4 pass. The limit computes to 1622016.Generated by Claude Code