Repository navigation
Move the Lean pin from v4.32.1 to v4.33.1 - #433
humuhumu33 wants to merge 6 commits into
Conversation
#420) SPEC.md §8.2's chapter module, lean-toolchain, both container images, every pinned workspace and fixture configuration, the language data, the schemas, the authority and ledger modules (re-acquired source archive SHA-256), the compiler constants, and the version-banner tests. Generated outputs follow in the regeneration commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every compiler-semantics ID moves once: language 1.0 df4317a1, 1.1 1fdcc6a3, 1.2 e7451506. Written by the owning commands only, in this order: check-calculus --write (the LCNF registry from the pinned Lean: no signature changed, only defining-source digests) to its fixed point, validate-model --write, lexlean lock in every project the previous compiler accepted (twice; the second pass changes nothing), check-fixtures --write, check-golden --write, check-production-export --write, verify-examples --write for every example but UOR Atlas, and a last check-calculus --write for the digests of the relocked compiler project. The seven negative fixtures whose lock is defective by design cannot be written by `lexlean lock`; as in the earlier identity waves only their identity fields follow (an ID equal to its language's previous current ID, the toolchain line, and the lean-toolchain digest). No fixture's diagnostic code changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kappa's generated outputs take the release side and are regenerated on the 4.33.1 identity in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I have marked this draft because its own acceptance section leaves Atlas records, the actual 4.32.1 refusal and controlled before/after timings unfinished. Current head Please preserve completed compatibility outputs and record the exact currently active writer/head here. The accepted ordering in #420 was source integration with #362's reviewed follow-ups, #405 and #396, then one v0.5 toolchain/identity wave after the active v0.4 Host/#402 wave. This PR's regeneration ran ahead of that integration. Do not start another regeneration or full matrix on an incomplete tree; finish any already-running atomic writer safely and retain its logs, then reconcile the shared source before the final wave. We will use this existing PR rather than duplicate the upgrade branch. The remaining evidence must use actual 4.32.1 through upgraded preflight (LLV7001 and no publication), a reproducible same-corpus baseline and after-run with per-example verify and total time, complete Atlas shards/join and final-head CI. Preserve frozen older-language runtime bytes and legitimate historical/wrong-version fixture exceptions. The timing section currently describes back-to-back measurements but says they are still pending; please distinguish planned methodology from completed measurements. |
afflom
left a comment
There was a problem hiding this comment.
Bounded independent source review found no additional implementation blocker in the authored pin-migration delta. Normative sources originate in spec/src; compiler/schema/project pins and generator templates follow the new version. Frozen older-runtime files are byte-identical, all 307 negative diagnostic files retain their codes, and the LCNF registry changes exactly 179 defining-source hashes with no other parsed changes. Token-table probing and archive reacquisition were not independently executed.
This is not merge approval. The branch is based on 2849449, before #407; current v0.5 is a8ad058. KA-05/06 differences against the current base are stale integration, not an authored revert, and the early regeneration cannot establish final integrated κ compatibility. The real old-version refusal remains absent: toolchain-mismatch plants 4.31.0, not the required actual 4.32.1 executable. Atlas, integrated-source compatibility, controlled per-example verify/total timings and full final-head CI remain outstanding. Keep 'no proofs broke' scoped to the disclosed projects actually verified, and #420 open until the coordinated final integration and evidence are complete.
kappa/lexlean.lock by lexlean lock, kappa/expected/build by check-golden --write, kappa/expected/verify by verify-examples --write; check-calculus and validate-model pass unchanged, and no other output moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every conflict is a generated output; each takes the release side and is regenerated on the 4.33.1 identity in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#396 moves the language-1.2 compiler-semantics ID (the runtime's Portable module), so the whole wave runs again on the merged tree, by the owning commands only: check-calculus --write to its fixed point, validate-model --write, lexlean lock in every project (twice), check-fixtures --write, check-golden --write, check-production-export --write, verify-examples --write for every example but UOR Atlas, and a last check-calculus --write. Languages 1.0 and 1.1 keep their 4.33.1 IDs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Record of the active writer and head, as requested. No writer is running. The current head is Commits on the branch:
The resulting IDs are 1.0 All writer logs are kept outside the tree, with per-step exit codes and seconds: phase 1, phase 2, fixtures, golden, verify-write and calculus for the first wave, the kappa wave, and the post-#396 wave. I can attach them. Compatibility found so far (4.33.1, Linux x86-64 container):
Still outstanding:
The frozen older-language runtime bytes are unchanged. |
afflom
left a comment
There was a problem hiding this comment.
Refreshed source/evidence review at7dd6361b: this head now retains #407 and actual landed #396. The checked kernel/slice/join/Host sources match that landing; frozen older runtime text and 307 negative code/exit sets are preserved. Current hosted honesty proves483 model/spec rows and five BDD meta tests; reproducibility passed. The partial draft run skips seven host/Atlas stages and is not complete acceptance.
The remaining #420 requirements are still real: actual4.32.1 executable refusal with LLV7001/no publication, controlled same-corpus per-example verify and total timings, Atlas compatibility and actual shard/join critical-path evidence, then the final integrated full gate. The current Atlas authored source and347 verification records have not been repaired for the disclosed Int.Linear/Nat.elimOffset failures. Please continue the bounded Atlas SOURCE repair on this existing branch, preserving declarations/proof guarantees, before the shared freeze; do not hand-edit its generated records or start another identity/product wave yet.
Keep the complete logs from the additional completed waves, and clarify the body’s “each moved once” wording so it describes a particular wave rather than the branch’s history. The reported Atlas reference count also needs its scan scope stated: the committed authored-src scan found23 Int.Linear constants/43 references in four modules; that is narrower than the reported47/six and is not execution evidence.
The final v0.5 source freeze must include reviewed #362 follow-ups, #405’s Host/maintenance/DF-19 forward integration and new draft #437 formatting isolation, in addition to retained #396/#407. I have read your no-active-writer handoff and agreement to coordinate. Keep this PR draft and #420 open; no further matrix or regeneration is requested by this review.
|
The integration inventory is now reconciled against the reviewed #405 + initial #362 + #437 source preparation ( The original pin commit has two schema conflicts with the new Mathlib contracts. Resolve those on the current schemas by changing only Future replay-cache infrastructure has been separated from the initial Mathlib delivery without dropping its pending claims/tests. #438 is consequently a future #338 prerequisite, not a new prerequisite for this upgrade. The existing Atlas source-repair request remains with this PR; preserve the old comparison corpus and controls before retargeting active sources. Final dependency resolution, identities/products, real old-version refusal, controlled timings, Atlas and full final-head CI remain required. |
|
To make the Atlas decision explicit: use option 1 from this PR body for the bounded source repair. Rename the affected Please keep the repair on this existing branch and separate the authored delta from generated records. A small direct 4.33.1 kernel check of the changed terms can establish the source repair; retain the exact toolchain/source/checker evidence and any failures. Complete Atlas shard/join and full acceptance still belong to the coordinated final tree. This does not authorize another identity/product regeneration or full matrix. |
|
Kept as the record of the 4.33.1 migration (Atlas findings: Generated by Claude Code |
Closes #420
This replaces the Lean pin
leanprover/lean4:v4.32.1(commitf054605aea4b840552cca2e725580bffd1e1b704) withleanprover/lean4:v4.33.1(commit819816b2e0a3bf405af45ae5c7af2491d8f5bee6). There is still one pin, one gate, and one set of expected outputs. The PR targetsrelease/v0.5, per AGENTS.md's release-line rule, and should not be merged before review.What changed
The first commit holds the hand-written sources:
lean-toolchain, both Dockerfiles, and every pinned workspace and fixture configuration (including the 307 negative fixtures);language/semantics*.tomland the schemas;*-4-33-1and the source archive's SHA-256 re-acquired (47c32e11…; the old archive still hashes to the committed6dec8667…, so codeload is stable).The second commit holds the regeneration, written only by the owning commands:
check-calculus --writeuntil nothing changes;validate-model --write;lexlean lockin every project the previous compiler accepted, twice (the second pass changes nothing);check-fixtures --write,check-golden --write,check-production-export --write;verify-examples --write;check-calculus --writefor the digests of the relocked compiler project.The seven negative fixtures whose lock is defective by design can't be written by
lexlean lock. As in the earlier identity waves, only their identity fields were substituted. No fixture's diagnostic code changed.Compiler-semantics IDs, each moved once:
89507c61…df4317a1…11732e9a…1fdcc6a3…49a667a8…(0b485471…after #396)69fd8ec2…What 4.33.1 broke
UOR Atlas does not verify yet, and this PR does not fix it. Atlas's source (
examples/uor-atlas/src) is native kernel-term data captured from 4.32.1's elaborator: proofs produced byomegaand linear-integer arithmetic, and compiledn + kmatch patterns. Two things in 4.33.1 break it:Int.LinearbecameInt.Internal.Linear(23 constants, 47 references in 6 modules). Lean's kernel rejectsLexLeanExample.Gluefirst, withunknown constant 'Int.Linear.norm_eq'. On a scratch copy, the pure rename madeGlueandPlacespass the kernel.Nat.elimOffset(fun h₁ h₂ => h₂ (add_right_cancel h₁)) is gone, with no counterpart. It appears once in each ofCensus,CensusClosure,GroupandScales.The other 904 of the 928 external constants Atlas references exist in 4.33.1 with unchanged types. Fixing Atlas means changing its source data. The options are now with the owner:
Nat.elimOffsetat its four nodes. The kernel checks the result, andMIGRATION.mdrecords it as the 4.33.1 migration.f972285f, ported to 4.33.1.Until then the Atlas shard jobs fail.
Every other project verifies under 4.33.1 with no generator change: elaboration,
leancheckerreplay, and the exact axiom audit all pass.Two Lean-version-specific inputs were re-derived rather than assumed:
tests/lcnf/registry.json, regenerated from the pinned Lean): no signature of any used constant changed; only the SHA-256s of the defining source files did.lean_tokens.rs): re-derived by probingLean.Parser.getTokenTableoverInit,StdandLeanunder both toolchains. The identifier-like token tables are identical (220 tokens), so the list stands.One generator-visible change: the new commit hash starts with a digit, so it is no longer a bare name in the tooling notation. The four hand-written tooling sources now quote it, which is the form the printer already emits in
language/lcnf-1.2/tooling/src/Extract.lex.tex.Acceptance
verifyrejects any reported Lean other than 4.33.1 with the existingLLV7001(see thetoolchain-mismatchfixture). The required negative (the real 4.32.1 executable through the upgraded preflight, producingLLV7001and publishing nothing) has not been run yet; thetoolchain-mismatchfixture plants 4.31.0, which is not that.git grep -F 4.32.1andgit grep -E '4[-_]32[-_]1|f054605'now hit onlyCHANGELOG.mdand dated evidence records. Those areVERIFICATION.mdmeasurement logs, theMIGRATION.mdfiles,tests/preservation-certificates/*-STATEMENTS.md, andtests/runtime-library/LAWS.md; they record what was run under 4.32.1 at named commits, and rewriting them would falsify history. The current-state lines ofVERIFICATION.md(theexamplesrow and the authority sentence) now say 4.33.1.git grep 4.32.1is a regex. It also matches long numerals in kernel-term data (for example…4232318…incompiler/proofsand the Atlas core data), so it can never return only CHANGELOG.just vv: CI on this PR runs the whole gate, Atlas shards included.Verification wall time per example
Not measured yet. No timing in this PR is a completed measurement. The planned method, per the maintainer's notes on #420: freeze the 4.32.1 comparison corpus; record the source heads, machine, width, build profile and cache policy; run the same corpus under 4.32.1 and 4.33.1 back to back on an idle machine with
cargo xtask verify-examplesandLEXLEAN_CI_TELEMETRY; and reportsteps.verify_msandwall_msfor each example. Atlas reports shard and join evidence and the critical-path elapsed time, not a sum of concurrent durations. Stale-lock refusals are not timing samples.Downstream (separate bumps)
Each needs a LexLean release from
release/v0.5that contains this change (v0.5.0); until then each stays on v0.4.0 and Lean 4.32.1:UOR-Foundation/template)#334
The Mathlib work for #334 exists only in open PR #362 (
feat/mathlib-import), so this PR doesn't touch it. A comment on #334 and #362 points its target at the Mathlib v4.33.1 tag, commit0df444a360eaa60ab8c11dca51a86af692955474.🤖 Generated with Claude Code