Skip to content

Move the Lean pin from v4.32.1 to v4.33.1 #420

Open

Description

@humuhumu33

Goal

Pin LexLean to leanprover/lean4:v4.33.1, so LexLean projects can import and verify against libraries built on that toolchain. The motivating consumer is the evm.fast challenge (Layr-Labs/evm.fast at 94a272e), whose fixed modules, Flapjack, and Mathlib are pinned to v4.33.1. Today SPEC.md §8.2 requires verify to reject that environment.

This is the toolchain decision that #334 leaves to the owner: replace the pin, not add a second one. A single pin keeps one gate, one compiler-semantics ID per language, and one set of expected outputs.

Requirements

  1. SPEC.md §8.2 names leanprover/lean4:v4.33.1, source commit 819816b2e0a3bf405af45ae5c7af2491d8f5bee6. lean-toolchain, the container image, and every pinned workspace and fixture follow.
  2. verify rejects any reported Lean version other than 4.33.1, with the existing diagnostic.
  3. Every expected output that records the toolchain (verification records, attestations, golden Lean, preservation certificates, negative fixtures) is regenerated by its owning command, never edited by hand.
  4. Every lemma, simp only set, or proof lowering that breaks under 4.33.1 is fixed in the generator, not patched in generated output.
  5. Every compiler-semantics ID moves once, and CHANGELOG.md records the change as breaking.
  6. Mathlib import: pin Mathlib, config entry, lock rows, explicit deps fetch #334 targets Mathlib at the v4.33.1 tag (commit 0df444a360eaa60ab8c11dca51a86af692955474, the revision evm.fast uses) rather than searching for a 4.32.1 commit.

Acceptance

  • just vv and the complete final-head CI pass on v4.33.1, including every Atlas shard and join; release.yml consumes that successful CI evidence.
  • A planted 4.32.1 environment fails verify with the version diagnostic.
  • Audit every active pin and current generated record for the new version and source commit. Inventory old-version/source-commit matches explicitly: only accurately labeled historical evidence and intentional wrong-version refusal fixtures may retain them. Preserve their provenance; no active pin may be exempted as history.
  • Report verification wall time before and after, per example.
  • Downstream (PrismPM, template, lexlean-mcp) is listed with the release they need; their bumps are separate issues.

Accepted release placement

Target release/v0.5 (0.5.0), coordinating final toolchain and identity regeneration with the agreed import/schema integration. Compatibility investigation may proceed before regeneration. See maintainer decision: #420 (comment) .

Activity

  1. afflom commented on Nov 3, 2026

    @afflom
    Member

    Maintainer decision: accept the single-pin upgrade for release/v0.5 (0.5.0), coordinated with #362's import/schema integration. The published Lean and Mathlib tags resolve to the exact commits in this issue; evm.fast 94a272e and its pinned Flapjack agree on 4.33.1. This establishes the consumer requirement and provenance, not compatibility.

    Compatibility inventory can begin now. Keep v0.4's current accepted pin while its release work lands, then carry the required forward integration through #405. Integrate the agreed v0.5 source before one serialized toolchain/identity regeneration; no concurrent pin or writer wave. Generated output must come from official writers, and any broken lowering or proof must be fixed at its source. Frozen older-language runtime text must not be silently changed.

    Two acceptance wording corrections preserve the intended guarantees: release.yml consumes complete CI/Atlas evidence rather than running the shards itself; and an unrestricted old-pin grep conflicts with both historical VERIFICATION evidence and the required planted 4.32.1 rejection. Audit every active pin and current generated record, with explicit historical and negative-test exceptions. Do not rewrite old measurements to claim they ran on 4.33.1. The full final-head gate, all Atlas stages, real old-version refusal and per-example before/after wall times remain mandatory.

    #334 should use the stated Mathlib revision on the new line, while its measured cold-fetch acceptance remains owed. #362 still claims loaded imports and axiom auditing only; changing the pin does not establish imported-closure replay or cache reuse. Downstream PrismPM/template/lexlean-mcp bumps should target the resulting 0.5.0 compiler and identities in separate issues. Please keep implementation in an issue-closing PR for #420.

  2. added this to the LexLean v0.5 milestone on Nov 3, 2026
  3. afflom commented on Nov 3, 2026

    @afflom
    Member

    Read-only source inventory is complete; no toolchain installation or competing regeneration has started. The active pin touches root/devcontainer/tool metadata, exact project/lock/build/compiler-input schema contracts, and v0.5's normative spec/src authority/ledger/chapter sources. Shared schemas affect all three compiler identities. The LCNF registry/tooling, GNAF generator and axiom-output parsing need real 4.33.1 compatibility checks. Keep the frozen portable-runtime-1.1.txt and core-decoder-1.txt bytes and RT-02 guarantees intact; a compatibility problem there needs an explicit decision, not silent replacement.

    The reviewed #362 follow-up at1144608af remains source preparation: its Mathlib demo/Lake/offline/speed/closure projects still need the accepted new pins and legitimate dependency regeneration. Coordinate that with refreshed #405 and #396 source integration in the v0.5 wave, after the active v0.4 Host/#402 wave.

    Before changing the pin, freeze the 4.32.1 comparison corpus and record source heads, machine, width, build profile and cache policy. Existing verify-examples telemetry provides steps.verify and overall wall_ms; report both per example. For Atlas, keep shard/join evidence and elapsed critical-path time instead of summing concurrent durations. Do not count stale-lock refusals as timing samples. The old-version negative must actually invoke the real 4.32.1 executable through upgraded preflight, produce LLV7001 and publish no verification; existing misleading-banner/RC/patch refusals remain. Complete final-head CI, Atlas join and release-evidence checks are still required.

  4. afflom commented on Nov 14, 2026

    @afflom
    Member

    Decision: release/v0.5 moves to Lean 4.33.1 (#433) and does not stay on 4.32.2. 4.33.1 already has the kernel soundness fix that #518 takes to 4.32.2: leanprover/lean4#14577 is f839b65 in v4.33.1's history. It also has the later kernel fixes #14806/#14807/#14808/#14849, which 4.32.2 does not have. 4.34.1 has the same fixes, but it is not the pin this issue accepted for evm.fast/Flapjack and Mathlib, so v0.5 takes 4.33.1. release/v0.4 keeps 4.32.2 (#518). When v0.4 is forward-merged into v0.5, the pin conflict resolves to 4.33.1.
    #433 lands last in the v0.5 queue (one serialized toolchain regeneration), and #362's Mathlib is pinned to the matching 4.33.1 tag.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions