Repository navigation
Conversation
Add the row page's PTC disclosure tier card (#989): one choice unifies both PTC rows in a single revision-checked save. An untouched old profile is never written, on-demand returns both rows to the absent key, disagreeing rows are named mixed and unified by the next choice, and a cancelled edit writes nothing. The tier rides the merged row page as a volatile string beside bashPath; the legacy per-mode form stays YAML-only. While the dynamic-tools bundle switch is off the card names the suspension and keeps the saved choice. The end-to-end suite saves through the real host writer, boots the shipped apply from the loader-merged profile, and asserts the full tier's loader-less first round carries exactly the permitted pool; switching the tier between saves applies to the next session.
This was referenced Nov 19, 2026
This was referenced Nov 19, 2026
Collaborator
Author
|
Superseded by #1033:18 张 OPS-PTC 卡的实现已随统一 PR 合入 main(本 PR 的提交已在 main 中),保留为评审记录。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #989
What was wrong
D3 (#987) published the explicit
fulltier and D4 (#988) aligned the diagnostics, but thedisclosurePolicykey stayed YAML-only: the row settings page had no entry, so an operator could not pick the tier without hand-editing the profile. Two suites were red on top of the in-progress D5 worktree:The e2e red had a second cause worth recording: the suite booted the session from the host settings describe view, which is the editable surface only — it strips YAML-only keys such as the
allowedToolscap and the worker path, so the full tier published the default pool even though the real writer had persisted everything correctly tocordis.patch.yml.The change
src/client/row-schema.ts:readDisclosure/disclosureDiffers/disclosureOps— the saved rows read as one tier ormixed;fullpins both PTC rows,on-demandreturns every row that carries the key to the absent default, so a profile saved through the card is letter-identical to one that never met it.src/client/row-form.tsx: the PTC disclosure tier card — two radios, one choice for both PTC rows, folded into the page's single revision-checked save. A cancelled edit writes nothing; amixeddisagreement is named and unified by the next choice; while the dynamic-tools bundle switch is off the card names the suspension (sign-off item 2 keeps its veto) and the saved choice is kept.src/client/locales.ts: en/zh strings for the card.src/settings/merged.ts:disclosurePolicyjoins the merged row page as a volatile string besidebashPath(the legacy per-mode form stays YAML-only); absent stays the on-demand default.test/settings-disclosure-e2e.test.mjs(new): the production chain twice over — the card's operations go through the real host settings writer and persist to the profile patch; the session then boots from the config the loader hands the row (profile layers merged, YAML-only keys included), runs the real native worker, and asserts the settled first-round surface plus one real binding call. The full leg proves a loader-less first round carrying exactly the permitted pool; the untouched old profile keeps the two-step on-demand path letter for letter; switching the tier between saves applies to the next session.test/settings-ui.test.mjs,test/settings-rows.test.mjs,test/settings-host.test.mjs,test/ptc-disclosure-policy.test.mjs: card interactions through real DOM events, schema/ops derivations, persistence through the real host writer, and the descriptor contract.docs/CHANGELOG.md:## [Unreleased]entry (bilingual).Deliberately not done: no publication-semantics change (D3/D4 own that), no teaching-copy change (P2), no diagnostics change (D4); no new dependency;
lib//runtime/untouched.Validation
npm run build, settings suites,ptc-disclosure-policy, worker-backed e2e,npm run check:size— real outputs below.row-form.tsxfailsthe disclosure card rendersand drops the e2e full leg back to the loader first round; removing the volatile field frommerged.tsfails theConfig.dictassertions insettings-rows/ptc-disclosure-policyand the host writer rejects the path op; removingdisclosureOpsfails the disclosure tests insettings-rows/settings-host.docs/CHANGELOG.md## [Unreleased]entry added.package.jsonuntouched.Environment
Linux x86_64, Node 24, based on
card/d4-integration-diagnostics@ 27af626 (upstream main @ 58f6e28), local worktree install.