Repository navigation
Conversation
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1028
What was wrong
Executor-only edits did not mark the row editor dirty. A host revision update could silently replace a typed or selected Bash path and discard the original write baseline. Switch-only drafts already preserved their baseline.
Saved/refused notices cached the translated text, so changing the page language left an existing notice in the previous language. A save completing after a language change had the same problem.
The change
Only
src/client/row-form.tsx,src/client/forms.tsx,test/settings-editor.test.mjsanddocs/CHANGELOG.mdchanged. No new dependencies, package/version changes, tool schema changes, worker/installation changes, live-profile installs, account/model calls or language-preference writes. Existing disclosure feature PR #1022 is separate.Validation
Baseline on 58f6e28:
The new suite failed against unchanged source for executor-only draft loss, candidate draft loss, saved/refused retranslation and in-flight retranslation. Three surrounding-behavior checks passed.
After the fix:
The local
settings-clientfailure isCannot identify fixture ownerin the unchangedtest/lib/harness.mjs: the Windows account returns anS-1-12-1-...SID while that helper only matchesS-1-5-.... The real host registry/lifecycle check and package check passed. No fixture, identity or permission policy was changed to bypass this failure.The complete
npm run verifyand worker/packaging release gate were not run for this scoped UI fix. These results are not a full release-gate pass. DOM tests use jsdom and form/executor stubs; existing settings UI/host suites also exercise the real pinned profile writer in temporary homes, not a daily profile.Upstream
pull_requestCI run: https://github.com/T-Auto/dsh-ops/actions/runs/44622701275. GitHub reportsconclusion: action_required; the run needs maintainer approval. The aggregateCI requiredcheck has not passed.Environment
Windows x64; Node.js v26.13.0. Base upstream main: 58f6e28. Local source checkout with existing development dependencies; no installation into a live profile.