Skip to content

fix(settings): preserve executor drafts and translate save notices - #1029

Open
chirag127 wants to merge 1 commit into
T-Auto:mainfrom
chirag127:fix/1028-settings-drafts-locale
Open

chirag127 wants to merge 1 commit into
T-Auto:mainfrom
chirag127:fix/1028-settings-drafts-locale

Conversation

@chirag127

@chirag127 chirag127 commented Nov 19, 2026 •

Copy link
Copy Markdown

Closes #1028

What was wrong

Executor-only edits did not mark the row editor dirty. A host revision update could silently replace a typed or selected Bash path and discard the original write baseline. Switch-only drafts already preserved their baseline.

Saved/refused notices cached the translated text, so changing the page language left an existing notice in the previous language. A save completing after a language change had the same problem.

The change

  • Keep executor choice and switches in the same editor draft, sharing its baseline, revision, reset and accepted-save lifecycle.
  • Retain saved/refused message keys and translate during rendering. Keep raw host errors literal.
  • Add eight DOM regression checks for executor-only, combined and switch-only drafts; conflict/reset and accepted-save behavior; candidate selection; live and in-flight status retranslation.
  • Update the bilingual Unreleased changelog.

Only src/client/row-form.tsx, src/client/forms.tsx, test/settings-editor.test.mjs and docs/CHANGELOG.md changed. No new dependencies, package/version changes, tool schema changes, worker/installation changes, live-profile installs, account/model calls or language-preference writes. Existing disclosure feature PR #1022 is separate.

Validation

Baseline on 58f6e28:

node scripts/build.mjs
build: compiled src/ to lib/ and copied 60 assets

node test/run.mjs settings-ui
settings-ui: all 24 checks passed

node test/run.mjs settings-editor
settings-editor: 5 of 8 check(s) failed

The new suite failed against unchanged source for executor-only draft loss, candidate draft loss, saved/refused retranslation and in-flight retranslation. Three surrounding-behavior checks passed.

After the fix:

node scripts/build.mjs
build: bundled 11 browser modules (95620 bytes)
build: generated PTC declarations for 18 capabilities (120684 bytes)
build: compiled src/ to lib/ and copied 60 assets

node test/run.mjs settings-editor settings-ui
settings-editor: all 8 checks passed
settings-ui: all 24 checks passed
2 suites passed; 0 skipped; 0 failed

node test/run.mjs settings
settings-editor: 8 passed
settings-ui: 24 passed
settings-rows: 14 passed
settings-host: 10 passed
settings-runtime: 14 passed
settings-client: 2 passed, 1 failed
Total: 72 checks passed, 1 failed; 5 suites passed, 1 failed, 0 skipped

node scripts/validate-manifest.mjs
validate-manifest: all 92 checks passed

node scripts/check-file-size.mjs
823 code files checked; all at or under 1000 lines

 git diff --cached --check
exit 0

The local settings-client failure is Cannot identify fixture owner in the unchanged test/lib/harness.mjs: the Windows account returns an S-1-12-1-... SID while that helper only matches S-1-5-.... The real host registry/lifecycle check and package check passed. No fixture, identity or permission policy was changed to bypass this failure.

The complete npm run verify and worker/packaging release gate were not run for this scoped UI fix. These results are not a full release-gate pass. DOM tests use jsdom and form/executor stubs; existing settings UI/host suites also exercise the real pinned profile writer in temporary homes, not a daily profile.

Upstream pull_request CI run: https://github.com/T-Auto/dsh-ops/actions/runs/44622701275. GitHub reports conclusion: action_required; the run needs maintainer approval. The aggregate CI required check has not passed.

Environment

Windows x64; Node.js v26.13.0. Base upstream main: 58f6e28. Local source checkout with existing development dependencies; no installation into a live profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(settings): preserve executor drafts and retranslate save status

1 participant