Skip to content

fix(settings): preserve executor drafts and retranslate save status #1028

Description

@chirag127

Concrete bugs

At main commit 58f6e28, two row-editor defects reproduce in React/jsdom with host form and executor service stubs:

  1. Start with an empty ready row at revision v1. Select Git Bash and type an executable path without changing a switch. Deliver a ready row at v2 containing another executor path. The unsaved path is replaced and Save becomes disabled without a mutation or warning. Executor state does not participate in the editor's dirty/baseline/revision lifecycle.
  2. Save a changed switch in English, then rerender the mounted form with the Chinese translator. The Save button updates, but saved/refused status remains in the previous language because the translated string is cached.

Scope and acceptance

  • Fix only src/client/row-form.tsx and src/client/forms.tsx.
  • Add focused DOM regression assertions under test/ and update the bilingual docs/CHANGELOG.md Unreleased section.
  • Preserve original baseline and revision for executor-only and combined drafts, including host rejection, reset, successful save, and unchanged executor behavior when only switches change.
  • Render saved/refused status using the active translator, while preserving raw host error text.
  • No generated-source edits, new dependencies, worker or installation architecture changes, live profile installation, account/model calls, or language preference writes.

Existing settings disclosure PR #1022 changes the same UI area for a different feature; this issue does not add disclosure controls.

I am claiming this bug-fix scope and will submit one focused PR with red/green evidence and the applicable local gates.

Activity

  1. chirag127 commented on Nov 19, 2026

    @chirag127
    Author

    I am claiming this issue. I will keep the fix limited to row-form.tsx, forms.tsx, settings UI regression tests, and the bilingual changelog. No worker, installation, or model behavior changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions