Skip to content

Setup gh actions integration#126

Merged
AwesomeTornado merged 13 commits into
developfrom
feature/gh-actions-integration
Jun 5, 2026
Merged

Setup gh actions integration#126
AwesomeTornado merged 13 commits into
developfrom
feature/gh-actions-integration

Conversation

@AwesomeTornado

Copy link
Copy Markdown
Member

Closes #125
@elsevers This PR is ready for review.

Notes

This PR adds Clang formatting checks on every push.

Self-Review

  1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? No
    These files are required, we cannot compress or delete any of them.

  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes

  3. Do all Markdown files follow the CONTRIBUTING article template? Yes

  4. Do all links work in the material that the PR is adding? Yes

  5. Is the PR configured to close the correct issue(s)? Yes

  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

Standard checklist

1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

@AwesomeTornado AwesomeTornado requested a review from elsevers as a code owner June 5, 2026 02:47
@AwesomeTornado AwesomeTornado self-assigned this Jun 5, 2026
@AwesomeTornado AwesomeTornado linked an issue Jun 5, 2026 that may be closed by this pull request
@elsevers elsevers changed the title Feature/gh actions integration Setup gh actions integration Jun 5, 2026

@elsevers elsevers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @AwesomeTornado.

Let's talk merge strategy: #102 changes motherboard_v1 to be mainboard and may have conflicts with the edits here to tx.c and main.c.

I suggest:

  1. Merge this PR (#126) now
  2. Merge #102 next (I can review and approve it now, since that code has been stable for a few weeks)
  3. New PR fixing gh actions

Other approaches work to. I have approved this pr (#102) if we want to go ahead and merge

@AwesomeTornado

Copy link
Copy Markdown
Member Author

@elsevers The gh actions will break upon renaming the folder structure, but it is very easy to fix. Do whatever you need to do, and I can fix gh actions after.

@AwesomeTornado AwesomeTornado merged commit af3fcae into develop Jun 5, 2026
1 check passed
@AwesomeTornado AwesomeTornado deleted the feature/gh-actions-integration branch June 5, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create plan to add clang to check style for code commits to AMDS

2 participants