Setup gh actions integration#126
Merged
Merged
Conversation
Updated script execution to use sudo for clang-format and check-format.
elsevers
approved these changes
Jun 5, 2026
elsevers
left a comment
Contributor
There was a problem hiding this comment.
Looks great @AwesomeTornado.
Let's talk merge strategy: #102 changes motherboard_v1 to be mainboard and may have conflicts with the edits here to tx.c and main.c.
I suggest:
- Merge this PR (#126) now
- Merge #102 next (I can review and approve it now, since that code has been stable for a few weeks)
- New PR fixing gh actions
Other approaches work to. I have approved this pr (#102) if we want to go ahead and merge
Member
Author
|
@elsevers The gh actions will break upon renaming the folder structure, but it is very easy to fix. Do whatever you need to do, and I can fix gh actions after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125
@elsevers This PR is ready for review.
Notes
This PR adds Clang formatting checks on every push.
Self-Review
Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? No
These files are required, we cannot compress or delete any of them.
Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
Do all Markdown files follow the CONTRIBUTING article template? Yes
Do all links work in the material that the PR is adding? Yes
Is the PR configured to close the correct issue(s)? Yes
Did the PR fully address the
Approachsection of the issue(s) it is closing? YesReviewer Instructions
Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.
Appendix
This section should be the same for all PRs. Do not edit this section when creating a PR.
Review Checklists
Checklists maintained by the eLev lab for research repositories include:
Standard checklist