Make generated group includes statically analyzable - #65
Merged
ChrisRackauckas merged 1 commit intoSep 4, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: OpenAI Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.151.0 Agent-Model: gpt-5.6-sol Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
ChrisRackauckas-Claude
force-pushed
the
codex/fix-explicitimports-analyzability
branch
from
September 4, 2026 09:55
fcc7229 to
6eeceb5
Compare
This was referenced Sep 4, 2026
Member
Author
|
Final CI audit after the test-placement amendment: all 12 required checks passed, including Julia 1/LTS/pre-release on Linux, macOS, and Windows, downgrade, Runic, and spelling. Test matrix: https://github.com/SciML/SciMLTesting.jl/actions/runs/33860723000 |
ChrisRackauckas
marked this pull request as ready for review
September 4, 2026 23:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Construct the generated group-body
includecall directly as an expression instead of quoting an interpolated call. The old source spelling looked like a runtime-dependentincludeto ExplicitImports, so it correctly refused to recurse into SciMLTesting and both source-analysis checks errored withUnanalyzableModuleException.The resulting expression still contains the same literal path when evaluated by
@safetestset. Once the source became analyzable, the stale@safetestsetimport was exposed and removed; the macro is referenced through its owningSafeTestsetsmodule. A package test now runs both real source-analysis checks.Verification
Failing before the fix, with the new test applied to
f5884b6:Passing after the fix:
Julia 1.10 LTS:
Commands:
The unfiltered self-audit improves from 16 passes, one failure, and three errors on main to 18 passes, one failure, and one error. The remaining stdlib-compat failure is addressed independently in #64; the non-public qualified-access findings are a separate concern and are not hidden here.
Docs were not built because no docstrings, documentation pages, or public API changed.
🤖 Generated with Codex CLI 0.151.0 (model: gpt-5.6-sol; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d)