Honor approved reexports in API docs QA - #66
Merged
ChrisRackauckas merged 1 commit intoSep 7, 2026
Merged
Conversation
Exclude approved external reexports from facade documentation checks while preserving caller-provided ignores and checks for package-owned names. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: OpenAI Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.151.0 Agent-Model: gpt-5.6-sol Agent-Session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d
Member
Author
|
Final CI audit: all 12 checks completed successfully and the PR is merge-clean.
Links:
|
ChrisRackauckas
marked this pull request as ready for review
September 7, 2026 06:22
This was referenced Sep 8, 2026
ChrisRackauckas
added a commit
that referenced
this pull request
Sep 17, 2026
Ships the approved-reexport handling in the API-docs QA check (#66), unreleased on master. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com> Agent-Harness: Claude Code 2.1.273 Agent-Model: claude-opus-5[1m] Agent-Session: 6a01e420-3436-4518-83cc-6cd853283cfb (local transcript; this harness publishes no conversation URL)
Merged
ChrisRackauckas
added a commit
that referenced
this pull request
Sep 17, 2026
Ships the approved-reexport handling in the API-docs QA check (#66), unreleased on master. Agent-Harness: Claude Code 2.1.273 Agent-Model: claude-opus-5[1m] Agent-Session: 6a01e420-3436-4518-83cc-6cd853283cfb (local transcript; this harness publishes no conversation URL) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
run_qaapply approved externalreexports_allownames to both public-API docstring and rendered-documentation checks. This restores the documented facade-package policy while preserving caller-provided ignores and continuing to check package-owned names even if they appear in the reexport allow-list.Root cause
The policy introduced in #62 initially merged approved external reexports into the API documentation ignore lists. Commit c745b75 immediately removed that routing while retaining the
reexports_allowinterface and its documented owner-documentation policy.run_qatherefore approved facade reexports in one check and then incorrectly required the facade to document/render those same externally owned bindings in the next check.The fix intersects
reexports_allowwith the package's actual external public reexports, then merges those names into bothignoreandrendered_ignore. The intersection is important: a locally owned name merely present inreexports_allowis still checked.Failing before
The new integration test was run against the unfixed source:
Passing after
Other verification
The repository has no Documenter build entrypoint. Its rendered public-API behavior is exercised directly by the regression suite.
An additional unfiltered self-QA probe exposed independent clean-main failures in stdlib compatibility metadata and ExplicitImports source analyzability. They are not hidden or mixed into this change and are addressed separately in #64 and #65. The remaining qualified-access audit is also being handled separately.
Links
🤖 Generated with Codex CLI 0.151.0 (model: gpt-5.6-sol; session: local session ID 01a0598f-11b9-72d1-91d9-b2fbb186557d)