Skip to content

Make generated group includes statically analyzable #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Sep 4, 2026
Merged

Make generated group includes statically analyzable #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/SciMLTesting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ using Pkg: Pkg
using PrecompileTools: @compile_workload, @setup_workload
using TOML: TOML
using Test: Test, @testset, @test, @test_broken
using SafeTestsets: SafeTestsets, @safetestset
using SafeTestsets: SafeTestsets
using Aqua: Aqua
using ExplicitImports: ExplicitImports
# REPL provides the public `@doc` lookup used on Julia 1.10, before `Docs.hasdoc`
Expand Down Expand Up @@ -1891,7 +1891,7 @@ function _run_body(body; label::AbstractString = "Group")
GlobalRef(SafeTestsets, Symbol("@safetestset")),
LineNumberNode(@__LINE__, @__FILE__),
string(label),
Expr(:block, :(include($path))),
Expr(:block, Expr(:call, :include, path)),
)
Core.eval(Main, expr)
elseif _callable(body)
Expand Down
7 changes: 7 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,8 @@ function Test.finish(ts::ProbeTestSet)
return ts
end

using ExplicitImports

@testset "SciMLTesting" begin
@testset "current_group" begin
# Default when unset.
Expand Down Expand Up @@ -917,6 +919,11 @@ end
@test FakeExplicitImports.PUBLIC_CALLED[] == (VERSION >= v"1.11")
end

@testset "SciMLTesting source analyzability" begin
@test ExplicitImports.check_no_implicit_imports(SciMLTesting) === nothing
@test ExplicitImports.check_no_stale_explicit_imports(SciMLTesting) === nothing
end

@testset "generated enum modules are excluded from source analysis" begin
@test SciMLTesting._generated_enum_modules(EnumFixture) == (EnumFixture.Generated,)
kwargs = SciMLTesting._explicit_imports_kwargs(
Expand Down
Loading