Repository navigation
webui: toolbar polish (banner placement, transient errors, wrapping, fullscreen, OCR copy) - #47
Merged
Merged
Conversation
- The open toolbar covered the no-password banner; move the banner to the bottom while the toolbar is open. - Toolbar errors stayed until the next reconnect; clear each after six seconds (or on click), show the full text on hover, and hide the empty slot. Errors on the Connect card are unchanged. - On narrow windows the toolbar overflowed both edges; cap its width and let it wrap, with button labels kept on one line. - Quality +/- no longer send a request when already at the limit, and are disabled there. - Fullscreen now toggles, and a browser refusal is shown instead of an unhandled promise rejection. - The OCR result has a Copy button, with an execCommand fallback since the Clipboard API is unavailable over plain http. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 4c · project thread
Summary
Before: the no-password banner overlapped the open toolbar; toolbar errors stayed forever; on narrow screens the toolbar was clipped; the quality −/+ buttons kept sending requests at 10%/100%; the fullscreen button could only enter fullscreen and failed silently; OCR results had no copy button.
After:
execCommand("copy")fallback because the device is usually opened over plain http where the Clipboard API is missing.How
util.rs:toggle_fullscreen()andcopy_text()call the browser APIs throughReflectand await the returned promises so rejections become messages.app.rs: error auto-clear effect keyed on the message text; quality rounding and early return; banner getsclass:lowwhen the toolbar is open.index.html: toolbarflex-wrap, disabled button style,.tb-err:emptyhidden,.nopw-banner.low.Cargo.toml: adds theNavigatorandNodeweb-sys features.Testing
cargo +nightly fmt --all(CI)cargo +nightly clippy --workspace --release --all-targets -- -D warnings(CI)cargo +nightly test --workspace(CI)trunk build --lockedand wasm32 clippy incrates/rkvm-web(CI)/returns 200, 4K60 video plays, startup log has no WARN/ERROR.Checklist
#[allow(...)]suppressions and no newunwrap()/expect()in production pathsMissedTickBehavior::Delayrkvm-protoRound 2 of the web UI retest fixes (minor issues). The five round-2 branches merge onto
devtogether without conflicts.🤖 Generated with Claude Code
https://claude.ai/code/session_01PbdzY6PfT28goR4BhqdsXR
Generated by Claude Code