Repository navigation
webui: fix the quality + button rendering as text - #51
Merged
Merged
Conversation
In view!, `disabled=move || quality.get() >= 0.95` ended the tag at the `>`, so the button showed "= 0.95 title =Raise stream quality>+" and stayed disabled, leaving no way to raise quality again. Brace both quality comparisons; no other view! attribute uses a bare < or >. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 4c · project thread
Summary
Before (regression from #47): the stream quality "+" button rendered as garbled text and stayed disabled, so quality could never be raised.
After: both quality buttons render normally; "+" is disabled only at 100% and "−" only at 10%.
How
In the
view!macro an unbracedquality.get() >= 0.95inside thedisabled=attribute was parsed with the>closing the tag, so the rest leaked into the button body. Wrapping both comparisons in braces (move || { ... }) keeps the whole expression in the attribute.Testing
cargo +nightly fmt --all(CI)cargo +nightly clippy --workspace --release --all-targets -- -D warnings(CI)cargo +nightly test --workspace(CI)trunk build --lockedand wasm32 clippy incrates/rkvm-web(CI)Checklist
#[allow(...)]suppressions and no newunwrap()/expect()in production pathsMissedTickBehavior::Delayrkvm-proto🤖 Generated with Claude Code
https://claude.ai/code/session_01PbdzY6PfT28goR4BhqdsXR
Generated by Claude Code