Repository navigation
webui: stop the toolbar wrapping at half the window width - #52
Merged
Merged
Conversation
With position: fixed and left: 50%, the toolbar's available width was only half the viewport, so at 696px it wrapped into five rows and covered the top of the video. Size it to its content (width: max-content) and keep the viewport cap, so it only wraps when it truly does not fit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 4c · project thread
Summary
Before (regression from #47): the toolbar wrapped into several rows even on normal-width windows, because the absolutely positioned,
translateX(-50%)toolbar shrank to about half the viewport onceflex-wrapwas on.After: the toolbar sizes to its content on one row and only wraps when the window is actually narrower than the toolbar.
How
Adds
width: max-contentto.toolbar; the existingmax-width: calc(100vw - 16px)still caps it on narrow screens.Testing
cargo +nightly fmt --all(CI)cargo +nightly clippy --workspace --release --all-targets -- -D warnings(CI)cargo +nightly test --workspace(CI)trunk build --lockedand wasm32 clippy incrates/rkvm-web(CI)Checklist
#[allow(...)]suppressions and no newunwrap()/expect()in production pathsMissedTickBehavior::Delayrkvm-proto🤖 Generated with Claude Code
https://claude.ai/code/session_01PbdzY6PfT28goR4BhqdsXR
Generated by Claude Code