Conversation
Contributor
juelg
commented
Jun 2, 2025
juelg
commented
- cameraset implementation are realized with composition instead of inheritance
- camera specific settings such as resolution are at the camera config level not the cameraset level
- multiple camerasets are possible, this allows to have realsense and digits both represented by a single camera wrapper
- Limitation: currently there is only support for a common single frame rate, as otherwise the complexity would increase massively
juelg
force-pushed
the
juelg/refactor-camera
branch
from
9ee6817 to
7739d57
Compare
juelg
force-pushed
the
juelg/refactor-camera
branch
from
7739d57 to
3ebb182
Compare
put base camera config into cpp code
juelg
force-pushed
the
juelg/refactor-camera
branch
4 times, most recently
from
ece7875 to
e31c766
Compare
Contributor
Author
|
@khaledmohamed00 I finished the camera refactoring. The only thing with which I am not happy atm is that we now have set of sets on the hardware part. It would be good to refactor the code that we only have the camera set which contains single cameras, but that would require to let the real sense class represent only a single camera. I have checked already that it should be possible to do so on the realsense API level. |
- each camera can be configured individually - HardwareCameraSet uses HardwareCamera interface with composition instead of inheritance - BaseCameraConfig moved to cpp - removed digit camera set wrapper as camera set wrapper is used now
juelg
force-pushed
the
juelg/refactor-camera
branch
from
e31c766 to
e7f839e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.