feat(digit_cam): Add DIGIT tactile sensor support to RCS#188
Merged
Conversation
refactor the digit_cam feature to be consistent with the latest modifications in the master branch
- change digit_frame key in observation to digit_frames - remove rgb key from digit_frames
- factory produces digit class and not config - cleaned digit config and adapted to existing camera logic; moved example value to example script - removed set_config as it would need to reinitialize the cameras - cleaned digit import paths - added digit to exported modules - adapted info dict to represent digit explicitly
remove width and height properties in digit config and moved them to default factory
Contributor
|
Thanks! I went over the code and adjusted the logic to fit the current camera code a bit closer. I also moved the digit into the camera folder as I want to refactor the camera code to be able to have the digit implemented as a true camera. That would save us a bit of redundant code. You can see my progress at #189 . I would also like to remove the example code for two reasons: We dont have example code for the normal camera and there is no digit in simulation. The examples should just show case the basic functionality and do not have to include every support sensor. This also reduces the amount of internal dependencies that need to be updated. |
juelg
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(digit_cam): Add DIGIT Tactile Sensor Support to RCS
Description
This PR adds support for the DIGIT tactile sensor to the
rcslibrary. It introduces a new module (digit_cam) which allows integration and communication with one or more DIGIT sensors. You can specify the number of connected devices and their serial numbers directly in the configuration.Key Features
camerasdictionary using their unique identifiers(serial number).Module Structure & Additions
1. New Directory:
robot-control-stack/python/rcs/digit_cam/2. New Configuration and interface Class:
located in
robot-control-stack/python/rcs/digit_cam/digit_cam.pyInterface Class:
DigitCam(BaseHardwareCameraSet)Inherits from
BaseHardwareCameraSetand implements:initialize()_poll_frame()Configuration Class
Example configuration:
3. New Wrapper Class:
robot-control-stack/python/rcs/envs/base.py
DigitCameraSetWrapperinherits fromCameraSetWrapperimplements:
observationThis adds
digit_framesto the observation dictionary:Resolution and Frame Rate Options
QVGA:
VGA:
Example Added
robot-control-stack/python/examples/env_cartesian_control_digit.pyThis example demonstrates how to use the new DIGIT sensor interface for the Cartesian control example.
Checklist