Revert sketchlib-rust path dependency workarounds (closes #154)#160
Merged
milindsrivastava1997 merged 1 commit intomainfrom Mar 6, 2026
Conversation
…blic - Add sketchlib-rust git dependency to asap-query-engine/Cargo.toml - Remove workspace exclude for sketchlib-rust from root Cargo.toml - Remove sketchlib-rust/ from .gitignore - Remove sketchlib-rust rsync entry from asap-tools/components.conf - Uncomment series.rs and query.rs in promsketch_store - Remove stale commented-out private-repo CI steps from rust.yml - Remove stale commented-out secret-based build from Dockerfile - Regenerate Cargo.lock Closes #154 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
milindsrivastava1997
approved these changes
Mar 6, 2026
milindsrivastava1997
deleted the
154-revert-sketchlib-rust-path-dependency-once-it-is-open-sourced
branch
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
ProjectASAP/sketchlib-rustis public, this removes all the temporary workarounds:sketchlib-rustas a git dependency inasap-query-engine/Cargo.tomlexclude = ["sketchlib-rust"]from root workspaceCargo.tomlsketchlib-rust/from.gitignoresketchlib-rustfromasap-tools/components.confpromsketch_store/series.rsandquery.rsrust.ymlandDockerfileCargo.lockCloses #154