Skip to content

Revert sketchlib-rust path dependency workarounds (closes #154) #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milindsrivastava1997 merged 1 commit into from
Mar 6, 2026
Merged

Revert sketchlib-rust path dependency workarounds (closes #154) #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ jobs:
steps:
- uses: actions/checkout@v4

# - name: Configure git for private dependencies
# run: git config --global url."https://x-access-token:${{ secrets.PRIVATE_REPO_TOKEN }}@github.com/".insteadOf "https://github.com/"

# - name: Clone sketchlib-rust
# run: git clone https://github.com/ProjectASAP/sketchlib-rust.git

- name: Install Rust
uses: dtolnay/rust-toolchain@stable
with:
Expand Down Expand Up @@ -81,12 +75,6 @@ jobs:
steps:
- uses: actions/checkout@v4

# - name: Configure git for private dependencies
# run: git config --global url."https://x-access-token:${{ secrets.PRIVATE_REPO_TOKEN }}@github.com/".insteadOf "https://github.com/"

# - name: Clone sketchlib-rust
# run: git clone https://github.com/ProjectASAP/sketchlib-rust.git

- name: Install Rust
uses: dtolnay/rust-toolchain@stable
with:
Expand Down Expand Up @@ -145,7 +133,3 @@ jobs:

- name: Build Docker image
run: docker build -f asap-query-engine/Dockerfile -t sketchdb-queryengine-rust:latest .
# run: |
# echo "${{ secrets.PRIVATE_REPO_TOKEN }}" > /tmp/git_token
# docker build --secret id=git_token,src=/tmp/git_token -f QueryEngineRust/Dockerfile -t sketchdb-queryengine-rust:latest .
# rm -f /tmp/git_token
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
target/
experiment_outputs/

# Private repo, vendored locally until open sourced (see GitHub issue)
sketchlib-rust/

# Runtime and generated files
metadata/
preprocessed_configs/
Expand Down
Loading