Skip to content

Revert sketchlib-rust path dependency once it is open sourced #154

@milindsrivastava1997

Description

@milindsrivastava1997

Context

`sketchlib-rust` (https://github.com/ProjectASAP/sketchlib-rust) is currently a private repo. As a temporary workaround, it is being vendored locally and rsynced to CloudLab nodes rather than fetched directly from GitHub by Cargo.

What was changed (and must be reverted)

  1. `Utilities/components.conf` — added `sketchlib-rust` so it gets rsynced to nodes. Remove this line:
    ```
    sketchlib-rust
    ```

  2. `.gitignore` — added `sketchlib-rust/` to prevent committing the private source. Remove this entry once the repo is public.

  3. Local clone at `asap-internal/sketchlib-rust/` — the repo source is vendored here. Delete it once the public repo is used directly.

Note: `QueryEngineRust/Cargo.toml` already uses the git dependency (PR ProjectASAP/asap-internal#434 kept/restored this). No change needed there.

Steps to revert

Once `ProjectASAP/sketchlib-rust` is made public:

  1. Remove `sketchlib-rust` from `Utilities/components.conf`
  2. Remove `sketchlib-rust/` from `.gitignore`
  3. Delete the local clone at `asap-internal/sketchlib-rust/`
  4. Regenerate `Cargo.lock` to pick up the latest public commit:
    ```bash
    CARGO_NET_GIT_FETCH_WITH_CLI=true cargo generate-lockfile
    ```

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions