-
Notifications
You must be signed in to change notification settings - Fork 0
Revert sketchlib-rust path dependency once it is open sourced #154
Description
Context
`sketchlib-rust` (https://github.com/ProjectASAP/sketchlib-rust) is currently a private repo. As a temporary workaround, it is being vendored locally and rsynced to CloudLab nodes rather than fetched directly from GitHub by Cargo.
What was changed (and must be reverted)
-
`Utilities/components.conf` — added `sketchlib-rust` so it gets rsynced to nodes. Remove this line:
```
sketchlib-rust
``` -
`.gitignore` — added `sketchlib-rust/` to prevent committing the private source. Remove this entry once the repo is public.
-
Local clone at `asap-internal/sketchlib-rust/` — the repo source is vendored here. Delete it once the public repo is used directly.
Note: `QueryEngineRust/Cargo.toml` already uses the git dependency (PR ProjectASAP/asap-internal#434 kept/restored this). No change needed there.
Steps to revert
Once `ProjectASAP/sketchlib-rust` is made public:
- Remove `sketchlib-rust` from `Utilities/components.conf`
- Remove `sketchlib-rust/` from `.gitignore`
- Delete the local clone at `asap-internal/sketchlib-rust/`
- Regenerate `Cargo.lock` to pick up the latest public commit:
```bash
CARGO_NET_GIT_FETCH_WITH_CLI=true cargo generate-lockfile
```