[k11kirky]

Problem

When a GitHub app installation is uninstalled or its token is revoked, the integration appears as "Connected" even though it can no longer reach GitHub. Users have no way to know their integration is broken or how to fix it.

Changes

• Tracks failed GitHub installation IDs by detecting errors from the per-integration repository fetch queries
• Exposes failedInstallationIds from useUserRepositoryIntegration so components can identify stale integrations
• Adds an integrationIsStale state in GitIntegrationStep when the current integration's installation ID appears in the failed list
• Replaces the "Connected" status indicator with a "Reconnect needed" warning when the integration is stale
• Shows an explanatory amber-colored message describing why the integration may have failed
• Adds a "Reconnect" button that silently disconnects the stale integration and immediately re-initiates the GitHub OAuth/app install flow
• Supports a silent option on the disconnect mutation to suppress the "GitHub disconnected" toast when reconnecting automatically

[k11kirky]

• feat(code): list all GitHub installations and allow adding another org #2001
• feat(code): detect stale GitHub integration and offer Reconnect #2000 👈 (View in Graphite)
• feat(code): add inline GitHub disconnect to onboarding step #1999
• feat(code): show persistent error state for GitHub connect failures #1998
• feat(code): show fast-path GitHub sign-in when current project has team install #1997
• feat(code): unify user-scoped GitHub connect into a shared hook #1996
• feat(code): cleaner GitHub integration onboarding step #1990
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx:390-396
**Silent disconnect failure may leave dangling integration**

If `disconnectMutation.mutateAsync` fails (e.g. a 5xx from the backend), the error is swallowed and `handleConnectGitHub()` is still called. The old stale integration record remains in the database while a new OAuth flow starts. Depending on whether the backend enforces uniqueness per user, this can result in two integration rows, and `invalidateGithubQueries` is never called (since `onSuccess` doesn't fire), so the cache retains the stale entry until the reconnect completes.

Consider invalidating the relevant queries in the catch path so the UI doesn't remain in an inconsistent state even when disconnect fails.

### Issue 2 of 2
apps/code/src/renderer/hooks/useIntegrations.ts:155-158
**Stale detection triggers on any error, not just auth failures**

Any error that survives React Query's retry budget (network timeouts, 5xx server errors, etc.) will add the installation to `failedInstallationIds` and show "Reconnect needed" to the user, even when the GitHub token itself is still valid. This could prompt unnecessary reconnects during a temporary backend outage.

If the API client surfaces HTTP status codes, consider restricting the stale signal to 401/403 responses only.

_{Reviews (1): Last reviewed commit: "feat(code): detect stale GitHub integrat..." | Re-trigger Greptile}

[greptile-apps]

Silent disconnect failure may leave dangling integration

If disconnectMutation.mutateAsync fails (e.g. a 5xx from the backend), the error is swallowed and handleConnectGitHub() is still called. The old stale integration record remains in the database while a new OAuth flow starts. Depending on whether the backend enforces uniqueness per user, this can result in two integration rows, and invalidateGithubQueries is never called (since onSuccess doesn't fire), so the cache retains the stale entry until the reconnect completes.

Consider invalidating the relevant queries in the catch path so the UI doesn't remain in an inconsistent state even when disconnect fails.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx
Line: 390-396

Comment:
**Silent disconnect failure may leave dangling integration**

If `disconnectMutation.mutateAsync` fails (e.g. a 5xx from the backend), the error is swallowed and `handleConnectGitHub()` is still called. The old stale integration record remains in the database while a new OAuth flow starts. Depending on whether the backend enforces uniqueness per user, this can result in two integration rows, and `invalidateGithubQueries` is never called (since `onSuccess` doesn't fire), so the cache retains the stale entry until the reconnect completes.

Consider invalidating the relevant queries in the catch path so the UI doesn't remain in an inconsistent state even when disconnect fails.

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Stale detection triggers on any error, not just auth failures

Any error that survives React Query's retry budget (network timeouts, 5xx server errors, etc.) will add the installation to failedInstallationIds and show "Reconnect needed" to the user, even when the GitHub token itself is still valid. This could prompt unnecessary reconnects during a temporary backend outage.

If the API client surfaces HTTP status codes, consider restricting the stale signal to 401/403 responses only.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/hooks/useIntegrations.ts
Line: 155-158

Comment:
**Stale detection triggers on any error, not just auth failures**

Any error that survives React Query's retry budget (network timeouts, 5xx server errors, etc.) will add the installation to `failedInstallationIds` and show "Reconnect needed" to the user, even when the GitHub token itself is still valid. This could prompt unnecessary reconnects during a temporary backend outage.

If the API client surfaces HTTP status codes, consider restricting the stale signal to 401/403 responses only.

How can I resolve this? If you propose a fix, please make it concise.

[k11kirky]

Merge activity

• May 4, 2:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 4, 3:16 PM UTC: Graphite rebased this pull request as part of a merge.
• May 4, 3:28 PM UTC: @k11kirky merged this pull request with Graphite.