Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

feat(code): cleaner GitHub integration onboarding step - #1990

Merged
k11kirky merged 1 commit into
mainfrom
05-04-feat_code_cleaner_github_integration_onboarding_step
May 4, 2026
Merged

k11kirky merged 1 commit into
mainfrom
05-04-feat_code_cleaner_github_integration_onboarding_step

Conversation

@k11kirky

@k11kirky k11kirky commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem

When a user is on the onboarding Git integration step and GitHub is already connected to another project, the UI only surfaced a single alternative project via a callout banner. This didn't handle the case where multiple other projects already have GitHub connected, and the callout placement made the flow feel disconnected from the primary action area.

Changes

  • Replaced the standalone callout banner with inline messaging directly within the GitHub connection section
  • When one other project has GitHub connected, the project name and org are shown inline with options to either connect GitHub on the current project or switch to the already-connected project
  • When multiple other projects have GitHub connected, a dropdown menu is rendered inline, allowing the user to browse and select among all connected alternatives before deciding to switch or connect fresh
  • The "Switch to" action is now a ghost button and "Connect GitHub" is promoted to a solid button, clarifying the preferred action
  • Removed the Callout import in favor of DropdownMenu to support the multi-project selection UI

@k11kirky
k11kirky marked this pull request as ready for review May 4, 2026 09:56
@greptile-apps

greptile-apps Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx:487-489
**Singular/plural grammar for "more"**

When there are exactly 2 alternative projects, `alternativeConnectedProjects.length - 1` equals `1`, so the rendered sentence reads: *"ProjectA + 1 more projects already have GitHub connected."* — `projects` should be singular (`project`) in that case.

Reviews (1): Last reviewed commit: "feat(code): cleaner GitHub integration o..." | Re-trigger Greptile

Comment on lines +487 to +489
{alternativeConnectedProjects.length - 1}{" "}
more
</button>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Singular/plural grammar for "more"

When there are exactly 2 alternative projects, alternativeConnectedProjects.length - 1 equals 1, so the rendered sentence reads: "ProjectA + 1 more projects already have GitHub connected." — projects should be singular (project) in that case.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx
Line: 487-489

Comment:
**Singular/plural grammar for "more"**

When there are exactly 2 alternative projects, `alternativeConnectedProjects.length - 1` equals `1`, so the rendered sentence reads: *"ProjectA + 1 more projects already have GitHub connected."* — `projects` should be singular (`project`) in that case.

How can I resolve this? If you propose a fix, please make it concise.

k11kirky commented May 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 4, 2:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 4, 2:36 PM UTC: @k11kirky merged this pull request with Graphite.

@k11kirky
k11kirky merged commit 8037dc7 into main May 4, 2026
16 checks passed
@k11kirky
k11kirky deleted the 05-04-feat_code_cleaner_github_integration_onboarding_step branch May 4, 2026 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants