This repository was archived by the owner on Aug 6, 2026. It is now read-only.
Repository navigation
feat(code): cleaner GitHub integration onboarding step - #1990
Merged
k11kirky merged 1 commit intoMay 4, 2026
Merged
Conversation
Contributor
Author
k11kirky
marked this pull request as ready for review
May 4, 2026 09:56
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx:487-489
**Singular/plural grammar for "more"**
When there are exactly 2 alternative projects, `alternativeConnectedProjects.length - 1` equals `1`, so the rendered sentence reads: *"ProjectA + 1 more projects already have GitHub connected."* — `projects` should be singular (`project`) in that case.
Reviews (1): Last reviewed commit: "feat(code): cleaner GitHub integration o..." | Re-trigger Greptile |
Comment on lines
+487
to
+489
| {alternativeConnectedProjects.length - 1}{" "} | ||
| more | ||
| </button> |
Contributor
There was a problem hiding this comment.
Singular/plural grammar for "more"
When there are exactly 2 alternative projects, alternativeConnectedProjects.length - 1 equals 1, so the rendered sentence reads: "ProjectA + 1 more projects already have GitHub connected." — projects should be singular (project) in that case.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx
Line: 487-489
Comment:
**Singular/plural grammar for "more"**
When there are exactly 2 alternative projects, `alternativeConnectedProjects.length - 1` equals `1`, so the rendered sentence reads: *"ProjectA + 1 more projects already have GitHub connected."* — `projects` should be singular (`project`) in that case.
How can I resolve this? If you propose a fix, please make it concise.
k11kirky
force-pushed
the
05-04-feat_code_cleaner_github_integration_onboarding_step
branch
from
May 4, 2026 11:55
ac6c480 to
0ff6301
Compare
This was referenced May 4, 2026
jonathanlab
approved these changes
May 4, 2026
Contributor
Author
k11kirky
deleted the
05-04-feat_code_cleaner_github_integration_onboarding_step
branch
May 4, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
When a user is on the onboarding Git integration step and GitHub is already connected to another project, the UI only surfaced a single alternative project via a callout banner. This didn't handle the case where multiple other projects already have GitHub connected, and the callout placement made the flow feel disconnected from the primary action area.
Changes
Calloutimport in favor ofDropdownMenuto support the multi-project selection UI