[k11kirky]

Problem

Users who connect their personal GitHub account during onboarding have no way to disconnect it without leaving the app. This makes it difficult to switch accounts or revoke access without going directly to GitHub or PostHog settings.

Changes

• Adds a Disconnect button to the GitHub integration section of the onboarding Git Integration step, visible when a GitHub integration is active.
• Clicking the button opens a confirmation AlertDialog that explains the scope of the disconnection (personal authorization only; the GitHub App installation in the org is unaffected).
• On confirmation, calls a new disconnectGithubUserIntegration API method that sends a DELETE request to /api/users/@me/integrations/github/{installationId}/.
• After a successful disconnect, relevant GitHub-related queries are invalidated and a success toast is shown. Errors surface via an error toast.
• Extracts the query invalidation logic into a shared invalidateGithubQueries helper so it can be reused across the connect and disconnect flows.

[k11kirky]

• feat(code): list all GitHub installations and allow adding another org #2001
• feat(code): detect stale GitHub integration and offer Reconnect #2000
• feat(code): add inline GitHub disconnect to onboarding step #1999 👈 (View in Graphite)
• feat(code): show persistent error state for GitHub connect failures #1998
• feat(code): show fast-path GitHub sign-in when current project has team install #1997
• feat(code): unify user-scoped GitHub connect into a shared hook #1996
• feat(code): cleaner GitHub integration onboarding step #1990
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx:595-608
**Dialog closes immediately on click, bypassing loading state**

`AlertDialog.Action` calls `onOpenChange(false)` synchronously when clicked (the event bubbles up from the inner `Button`). At that moment, `disconnectMutation.isPending` is still `false` in the `onOpenChange` closure — React hasn't committed the state update from `mutate()` yet. So the `onOpenChange` guard passes, `setDisconnectConfirmOpen(false)` is called, and the dialog closes immediately rather than staying open to show the spinner.

`e.preventDefault()` doesn't help here — it only prevents the browser's native default action, not programmatic React handlers higher in the tree.

Since `onSuccess` already closes the dialog explicitly, the simplest fix is to move the confirm button out of `AlertDialog.Action`:

```tsx
<Flex gap="3" mt="4" justify="end">
  <AlertDialog.Cancel asChild>
    <Button variant="soft" color="gray" disabled={disconnectMutation.isPending}>
      Cancel
    </Button>
  </AlertDialog.Cancel>
  <Button
    variant="solid"
    color="red"
    onClick={() => disconnectMutation.mutate()}
    disabled={disconnectMutation.isPending}
  >
    {disconnectMutation.isPending ? <Spinner size="1" /> : null}
    Disconnect
  </Button>
</Flex>
```

This keeps the `onOpenChange` guard meaningful and allows the spinner to be visible during the request.

_{Reviews (1): Last reviewed commit: "feat(code): add inline GitHub disconnect..." | Re-trigger Greptile}

[greptile-apps]

Dialog closes immediately on click, bypassing loading state

AlertDialog.Action calls onOpenChange(false) synchronously when clicked (the event bubbles up from the inner Button). At that moment, disconnectMutation.isPending is still false in the onOpenChange closure — React hasn't committed the state update from mutate() yet. So the onOpenChange guard passes, setDisconnectConfirmOpen(false) is called, and the dialog closes immediately rather than staying open to show the spinner.

e.preventDefault() doesn't help here — it only prevents the browser's native default action, not programmatic React handlers higher in the tree.

Since onSuccess already closes the dialog explicitly, the simplest fix is to move the confirm button out of AlertDialog.Action:

<Flex gap="3" mt="4" justify="end">
  <AlertDialog.Cancel asChild>
    <Button variant="soft" color="gray" disabled={disconnectMutation.isPending}>
      Cancel
    </Button>
  </AlertDialog.Cancel>
  <Button
    variant="solid"
    color="red"
    onClick={() => disconnectMutation.mutate()}
    disabled={disconnectMutation.isPending}
  >
    {disconnectMutation.isPending ? <Spinner size="1" /> : null}
    Disconnect
  </Button>
</Flex>

This keeps the onOpenChange guard meaningful and allows the spinner to be visible during the request.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/GitIntegrationStep.tsx
Line: 595-608

Comment:
**Dialog closes immediately on click, bypassing loading state**

`AlertDialog.Action` calls `onOpenChange(false)` synchronously when clicked (the event bubbles up from the inner `Button`). At that moment, `disconnectMutation.isPending` is still `false` in the `onOpenChange` closure — React hasn't committed the state update from `mutate()` yet. So the `onOpenChange` guard passes, `setDisconnectConfirmOpen(false)` is called, and the dialog closes immediately rather than staying open to show the spinner.

`e.preventDefault()` doesn't help here — it only prevents the browser's native default action, not programmatic React handlers higher in the tree.

Since `onSuccess` already closes the dialog explicitly, the simplest fix is to move the confirm button out of `AlertDialog.Action`:

```tsx
<Flex gap="3" mt="4" justify="end">
  <AlertDialog.Cancel asChild>
    <Button variant="soft" color="gray" disabled={disconnectMutation.isPending}>
      Cancel
    </Button>
  </AlertDialog.Cancel>
  <Button
    variant="solid"
    color="red"
    onClick={() => disconnectMutation.mutate()}
    disabled={disconnectMutation.isPending}
  >
    {disconnectMutation.isPending ? <Spinner size="1" /> : null}
    Disconnect
  </Button>
</Flex>
```

This keeps the `onOpenChange` guard meaningful and allows the spinner to be visible during the request.

How can I resolve this? If you propose a fix, please make it concise.

[k11kirky]

Merge activity

• May 4, 2:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 4, 3:06 PM UTC: Graphite rebased this pull request as part of a merge.
• May 4, 3:14 PM UTC: @k11kirky merged this pull request with Graphite.