Repository navigation
fix(pixel-gateway): strip trailing slashes on provider baseUrl when resolving completions target - #5872
Closed
vaibhavsrv wants to merge 1 commit into
Closed
fix(pixel-gateway): strip trailing slashes on provider baseUrl when resolving completions target#5872vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
…esolving completions target
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/bin/pixel_provider/runtime_gateway.py,pinned_target()resolves the upstream provider URL by concatenating{parts.scheme}://{host}:{port}{parts.path}/chat/completions. When an operator or provider configuration supplies abaseUrlwith a trailing slash (e.g.http://127.0.0.1:11434/v1/),parts.pathretains the trailing slash (/v1/), producing a double slash in the endpoint path:/v1//chat/completions. Many strict OpenAI-compatible upstream gateways reject double slashes with HTTP 404 Not Found, causing provider attempts to fail unexpectedly.This patch strips trailing slashes from
parts.pathprior to URL formatting, ensuring clean endpoint resolution regardless of whetherbaseUrlterminates with a trailing slash.Validation
pinned_target()withbaseUrl="http://127.0.0.1:11434/v1/"; confirmed baseline generatedhttp://127.0.0.1:11434/v1//chat/completions.test_pixel_gateway_trailing_slash.pypasses with exit code 0;pinned_target()resolves tohttp://127.0.0.1:11434/v1/chat/completionsfor both trailing and non-trailing slash inputs.Overlap check
ods/installers/macos/with zero overlap in pixel provider gateway.ods/scripts/llm-cold-storage.sh.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens upstream URL path normalization in the provider runtime gateway, not tool execution or credentials. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5863 at 1de196a without conflicts. Production and test diffs passed together; pixel provider runtime and credential contracts remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.