Repository navigation
fix(mode-switch): use portable case folding for Bash 3.2 compatibility - #5880
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
5 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/mode-switch.sh,switch_mode()checkedLLM_BACKENDandODS_MODEL_SWITCHBOARDcasing using Bash 4 case-modification parameter expansion:${configured_backend,,}and${switchboard_mode,,}. On systems running Bash 3.2 (notably default macOS shells using/bin/bash), runningmode-switch.shimmediately fails with/bin/bash: ${configured_backend,,}: bad substitution, preventing operators from inspecting mode status or switching inference targets.This patch adopts portable
tr '[:upper:]' '[:lower:]'case normalization, ensuring mode transitions and external routing validations execute reliably across both modern Bash 4+ and macOS default Bash 3.2 environments.Validation
mode-switch.sh cloudunder/bin/bashwith uppercase/mixed-case environment settings; confirmed failure with/bin/bash: ${configured_backend,,}: bad substitution.ods/tests/test_mode_switch_bash32.pypasses with exit code 0 under/bin/bash; switches mode cleanly and correctly enforces external LLM routing guardrails.Overlap check
Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens shell compatibility for mode switching across POSIX and Bash 3.2 platforms, not daemon runtime execution. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5871 at 81b881c without conflicts. Production and test diffs passed together; mode-switch contracts remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.