Repository navigation
fix(dependency-pins): handle escaped quotes when stripping inline comments - #5879
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 19, 2026
Closed
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/check-dependency-pins.py,_strip_inline_comment()iterates across characters in Compose lines and Dockerfile arguments to locate unquoted#inline comments. However, it only trackedin_singleandin_doublequote boolean states without checking for backslash escape characters (\). When a build argument or image tag value contains an escaped quote (e.g.\"or\') inside a quoted string followed by a#character, the escaped quote prematurely toggled the quote state toFalse. Consequently, the subsequent#character was erroneously treated as an inline comment and stripped, corrupting valid image tags and build arguments.This patch tracks the
escapedstate in_strip_inline_comment()so that backslash-escaped quote characters do not toggle quote boundaries, ensuring inline comment stripping only affects genuine unquoted comment prefixes.Validation
_strip_inline_comment(r'ARG IMAGE="quay.io/vendor/image:tag\"#build-arg"'); confirmed baseline prematurely truncated the line at#build-arg".ods/tests/test_dependency_pins_escaped_quotes.pypasses with exit code 0; preserved escaped quotes in both single and double quotes while cleanly stripping genuine comments.Overlap check
Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens string scanning and comment stripping in runtime dependency pin validation, not container image execution. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5871 at 81b881c without conflicts. Production and test diffs passed together; dependency lock and runtime pin contracts remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.