Skip to content

fix(zephyr-4.3): remove select ZEPHYR_LORA_BASICS_MODEM_MODULE - #2

Open
Mikefly123 wants to merge 1 commit into
feat/sx126x-external-rf-switch-gpiofrom
fix/zephyr-4.3-drop-lbm-module-select
Open

Mikefly123 wants to merge 1 commit into
feat/sx126x-external-rf-switch-gpiofrom
fix/zephyr-4.3-drop-lbm-module-select

Conversation

@Mikefly123

Copy link
Copy Markdown

What

Removes the select ZEPHYR_LORA_BASICS_MODEM_MODULE line from drivers/usp/Kconfig.

Why

ZEPHYR_LORA_BASICS_MODEM_MODULE was an external-module auto-generated Kconfig symbol in Zephyr <=4.2. Starting in Zephyr 4.3 it became an internal Zephyr symbol not exposed to external modules, so select-ing it now triggers a fatal Kconfig "direct dependencies" abort, breaking the build on Zephyr >=4.3.

Validation

@coderabbitai

coderabbitai Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@Mikefly123, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bd671372-a558-4d5b-ae34-18838c7aa94f

📥 Commits

Reviewing files that changed from the base of the PR and between bfacd43 and 4494d42.

📒 Files selected for processing (5)
  • drivers/usp/Kconfig
  • drivers/usp/sx126x/sx126x_board.c
  • drivers/usp/sx126x/sx126x_hal.c
  • drivers/usp/sx126x/sx126x_hal_context.h
  • dts/bindings/usp/semtech,sx126x-new-common.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…nalized in 4.3)

ZEPHYR_LORA_BASICS_MODEM_MODULE was an external-module auto-symbol in
Zephyr <=4.2. In 4.3 it became an internal Zephyr symbol and is not
exposed to external modules. Remove the select to avoid a fatal Kconfig
'direct dependencies 0' abort.
@Mikefly123
Mikefly123 force-pushed the fix/zephyr-4.3-drop-lbm-module-select branch from 35f734b to 4494d42 Compare July 31, 2026 03:01
@Mikefly123
Mikefly123 changed the base branch from main to feat/sx126x-external-rf-switch-gpio July 31, 2026 03:01
@Mikefly123

Copy link
Copy Markdown
Author

Stack position 2/6 of stack Lora-net#8: base #1. Next: #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant