Skip to content

fix(usp-main-2025): fix LR_FHSS_SRC_PATH for flattened lr_fhss_driver layout - #3

Open
Mikefly123 wants to merge 1 commit into
fix/zephyr-4.3-drop-lbm-module-selectfrom
fix/lr-fhss-src-path-flattened-layout
Open

Mikefly123 wants to merge 1 commit into
fix/zephyr-4.3-drop-lbm-module-selectfrom
fix/lr-fhss-src-path-flattened-layout

Conversation

@Mikefly123

Copy link
Copy Markdown

What

Fixes LR_FHSS_SRC_PATH in modules/usp_drivers/dev_env.cmake to no longer append a now-nonexistent lr_fhss_driver/src subdirectory suffix.

Why

Upstream usp (main-2025) removed the lr_fhss_driver/src/ subdirectory; lr_fhss_mac.c now lives flat in sx126x_driver/src, the same directory as LBM_SX126X_LIB_DIR. With the old suffix the cmake path pointed at a directory that no longer exists, breaking the build against current upstream usp.

Validation

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Mikefly123, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dea987b6-8b41-43de-843a-4142af7402a7

📥 Commits

Reviewing files that changed from the base of the PR and between bfacd43 and fe4a28c.

📒 Files selected for processing (6)
  • drivers/usp/Kconfig
  • drivers/usp/sx126x/sx126x_board.c
  • drivers/usp/sx126x/sx126x_hal.c
  • drivers/usp/sx126x/sx126x_hal_context.h
  • dts/bindings/usp/semtech,sx126x-new-common.yaml
  • modules/usp_drivers/dev_env.cmake

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

… layout

Upstream usp removed lr_fhss_driver/src/; lr_fhss_mac.c now lives flat
in sx126x_driver/src (same dir as LBM_SX126X_LIB_DIR). Drop the now-
invalid subdirectory suffix to fix the cmake path.
@Mikefly123
Mikefly123 force-pushed the fix/lr-fhss-src-path-flattened-layout branch from 93c6ec7 to fe4a28c Compare July 31, 2026 03:01
@Mikefly123
Mikefly123 changed the base branch from main to fix/zephyr-4.3-drop-lbm-module-select July 31, 2026 03:01
@Mikefly123

Copy link
Copy Markdown
Author

Stack position 3/6 of stack Lora-net#8: base #2. Next: #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant