Skip to content

i18n: add missing Romanian translations for 8 keys - #24

Merged
MehdiMamas merged 2 commits into
MehdiMamas:mainfrom
HarshRajSinghania:i18n/ro-missing-keys
Nov 11, 2026
Merged

MehdiMamas merged 2 commits into
MehdiMamas:mainfrom
HarshRajSinghania:i18n/ro-missing-keys

Conversation

@HarshRajSinghania

Copy link
Copy Markdown
Contributor

Summary
Adds the 8 missing keys in the Romanian locale file so they no longer fall back to English.

Motivation
Addresses #21. The Romanian UI strings were missing 8 keys present in English, causing fallback.

Implementation
Translated the keys into Romanian and added them to src/lib/locales/ro.json in the corresponding locations:

  • dashboard.hidden
  • rules.quickLaunchOnlyPaused
  • settings.protectionChecker and settings.protectionCheckerHint
  • settings.quickLaunchOnly and settings.quickLaunchOnlyHint
  • errors.generic and errors.ruleFailures (kept the {count} placeholder)

The file remains valid JSON. No other keys were changed.

Testing

  • Validated the JSON structure
  • Keys match the English ones in position and placeholders

Note: Could not run pnpm build/test in this environment, but the change is a pure locale addition as specified in the issue.

HarshRajSinghania and others added 2 commits November 10, 2026 14:07
Adds the 8 keys that were falling back to English in the Romanian locale:
- dashboard.hidden
- rules.quickLaunchOnlyPaused
- settings.protectionChecker / protectionCheckerHint
- settings.quickLaunchOnly / quickLaunchOnlyHint
- errors.generic / ruleFailures (preserving {count})

Fixes MehdiMamas#21
@MehdiMamas

Copy link
Copy Markdown
Owner

Thank you @HarshRajSinghania for picking up the missing Romanian translations! The pushed file had ended up as a placeholder instead of the translated JSON, so I restored ro.json and added the 8 strings you listed (the capture status, Quick Launch only mode, the protection checker settings and the error messages) on top of your branch. Merging now, and you'll be credited in the release notes.

@MehdiMamas
MehdiMamas merged commit 5b6db91 into MehdiMamas:main Nov 11, 2026
1 check passed
@MehdiMamas

Copy link
Copy Markdown
Owner

This is now live in v2.3.4. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants