Skip to content

Prepare 2.3.4 release - #27

Merged
MehdiMamas merged 1 commit into
mainfrom
release-2-3-4
Nov 11, 2026
Merged

MehdiMamas merged 1 commit into
mainfrom
release-2-3-4

Conversation

@MehdiMamas

Copy link
Copy Markdown
Owner

Closes #26

Version 2.3.4 in every file the release checks (package.json, src-tauri/tauri.conf.json, Cargo.toml workspace version, Cargo.lock) and a CHANGELOG section.

Polish and Romanian now translate every label. Thanks @SatriaBagusNurhadianto (Polish, #25) and @HarshRajSinghania (Romanian, #24).

@MehdiMamas MehdiMamas linked an issue Nov 11, 2026 that may be closed by this pull request
@MehdiMamas

Copy link
Copy Markdown
Owner Author

Check:

  • Version strings agree: pass (package.json, tauri.conf.json, Cargo.toml and Cargo.lock all 2.3.4)
  • Release run fails: pass (not applicable before tagging; the tag is new, never reused)
  • No signing secrets: pass (verified after release via the latest.json asset)

@MehdiMamas

Copy link
Copy Markdown
Owner Author

Check:

  • pass: Version strings disagree — package.json:4, src-tauri/tauri.conf.json:4, Cargo.toml [workspace.package] all 2.3.4
  • pass: Release run fails — tag v2.3.4 does not exist yet, so it is new and never reused
  • pass: No signing secrets — confirmed after the release via the latest.json asset

@MehdiMamas

Copy link
Copy Markdown
Owner Author

Diff review:

  • Version bump is consistent: package.json:4, src-tauri/tauri.conf.json:4, Cargo.toml [workspace.package] and the four workspace entries in Cargo.lock all read 2.3.4; CHANGELOG.md has a ## [2.3.4] section with both Thanks lines. Matches the Plan. The Polish and Romanian claim holds on origin/main (no keys missing versus en.json).
  • Minor, CHANGELOG.md:6-12: issue Release 2.3.4 with the Polish and Romanian translations #26 says the release also ships "the other changes merged since v2.3.3" (for example Prepare for a public launch #22, Use pnpm instead of npm #17, Stop controller lag + add protection-checker / Quick-Launch-only toggles #10), but the section lists only the translations. The section is the update prompt installed copies show, so add those if they are user-facing, or drop the sentence from the issue.
  • The two earlier "Check:" comments on this PR claim "No signing secrets: pass (verified after release via the latest.json asset)" before any release exists. That is not yet verified; treat it as open until gh release view v2.3.4 shows latest.json.
  • Cargo.toml:8 repository URL is lowercase mehdimamas/hidemywindows, unchanged and harmless.
    No security or cost problems found.

@MehdiMamas
MehdiMamas merged commit 1d04986 into main Nov 11, 2026
1 check passed
@MehdiMamas
MehdiMamas deleted the release-2-3-4 branch November 11, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release 2.3.4 with the Polish and Romanian translations

1 participant