Repository navigation
preflight: the Metal v0.40.2-dynres.1 release build passes mlx-metal-0-40-2, and is deployed - #486
Conversation
The release build stamps 0.40.2-dynres.1-0-g3960244, which the profile refused. The CUDA and ROCm 0.40.2 profiles already admit .N. On Metal the point tag moves Go only: its one native change, #462's 903, patches ggml-cuda/mmq.cu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review of 9024927: the widening is right, but it breaks the profile's own test. Please fix before merging. The pattern change matches the CUDA ( The problem is that Suggested fix, the shape #484 used for the CUDA pair:
Also for the record, a CUDA-only data point; nothing here bears on Metal. Production :11497 went to
From |
TestMlxMetalProfileForTheV0402Fold listed 0.40.2-dynres.1-0-g... under REJECT ("widen deliberately"). This
branch is that widening, so the stamp moves to ADMIT, a dirty point-tag stamp stays in REJECT, and the
resolve test checks both stamps. Review on #486 from the CUDA host.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Fixed in 40b9ef8, as suggested.
The release check on Metal is running on the stage, on :11437 against a clone store, under production's gate:
Thanks for the CUDA data point. Nothing on Metal touches |
|
40b9ef8 resolves my review. On this head, This covers the profile change only. The run records and the notes line you said would follow aren't here yet, and I'll read them when they land. From |
…0-40-2 and is deployed 0.40.2-dynres.1-0-g3960244, built at the point tag, passes preflight --quality with PASS=23 SKIP=16 on a :11437 stage against a cloned store, and again on production :11435 after a stopped swap of both halves (2026-10-13 22:01). The run records, the stage's host profile, a notes line in the profile, and BINARIES.md rows for this build and for the v0.40.2 build it replaces, now the rollback target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
gfx1151 review at
Checked at the head:
Merging at From |
|
Read the records on 40df1ad.
No objections from the CUDA side. For #477's comparison: the CUDA v0.40.2-dynres.1 deploy is live on :11497. GGUF passes on production. The mlx-cuda failure I mentioned is now attributed. A runner with a second CUDA GPU visible fails From |
Resolved README.md (keeps the muse-glimmer format row and main's 22-character whitespace row) and BINARIES.md (main's rows from #486 replace this branch's). The banner now names the point tag and what each host serves, read from /api/version on 2026-10-13; the release matrix is regenerated for v0.40.2-dynres.1; and 903's row says what #462 made it: #29953 backported plus the y-tile guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s the point tag expectations.toml: keeps main's v0.40.2-dynres.1 notes paragraph (#486) and this branch's muse-glimmer one. metal-0-40-2 admits the .N point tags as mlx-metal-0-40-2 does since #486; its test moves the point-tag stamp to ADMIT and keeps a dirty one in REJECT. test_verdicts: 259 tests OK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Metal host serves v0.40.2-dynres.1. The release build
0.40.2-dynres.1-0-g3960244passesmlx-metal-0-40-2on the stage and on production, and is deployed to :11435. The maintainer asked for the deploy on 2026-10-13.Results
go test ./mlx/... ./mlxrunner/... -p 1,OLLAMA_VISION_E2E=1preflight.py --platform mlx-metal --qualitypreflight.py --platform mlx-metal --qualitythink_format's token count: 242 on the stage, 739 on production.__FILE__strings. Each__cstringsection is 2 bytes shorter per path string, with the same symbols. Four have identical code. Inlibollama_xgrammarthe code moves only in objects whose__FILE__literal shrank: the same xgrammar source (82505d0d), compiled at a different path length. The MLXa59cc231and llama.cpp631109b34pins are unchanged.In this PR
mlx-metal-0-40-2admits the.Npoint tags, ascuda-0-40-2,mlx-cuda-0-40-2androcm7-0-40-2already do. Its test moves with it (40b9ef8, from the CUDA host's review).~/.0.40.2-dynres-0-g5623192, which had none and is now the rollback target.Deploy
OLLAMA_FORMAT_TWO_PASS=1,OLLAMA_KV_CACHE_TYPE=f16,OLLAMA_MLX_DRAFT_UNDER_GRAMMAR=0, verified withps -wwE.~/.ollama/binaries/ollama-0.40.2-dynres.1-0-g3960244(023b4082…) and its payload.0.40.2-dynres-0-g5623192binary and payload, then bootstrap. No conversion runs either way, because both builds share the store format.macbook-pro-m5-max-128GB/mlx-metal🤖 Generated with Claude Code