Repository navigation
refactor: clarify parser mode and stabilize test seams - #54
Merged
Merged
Conversation
choskeli
marked this pull request as ready for review
October 28, 2026 02:21
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests depended on private callback names, exact YAML indentation, or comments and logging in the mutation runner. Replace those accidental dependencies with captured listener references, parsed YAML step selection, and bounded AST selection of complete runner policy spans. Regressions retain intervening statements, execute an extra promotion between guards, reject preceding/trailing/nested out-of-span promotions, tolerate formatting/logging changes, and detect a deliberately reattached renamed listener.
The selector accepts the labeled outer try introduced by PR #56. Its admission span includes and executes
routingIdentity; the new fixture checks its value and initialization-before-read order. Deliberately omitting that initialization fails the fixture. The contiguous spans, recursive promotion-bounds check and PR #56 diagnostic assertions are preserved.Clarify three private names: the parser's
capacityRequiredflag becomessuccessorEvidenceOnly, and the mutation helpers becomerunFreshShardCampaignandassertCurrentShardTests. Replace the misleading whole-parser scope error with “Mutation scope differs from expected scope,” which also describes shard/range mismatches accurately. Scope comparison, validation order, cache trust and mutation semantics are unchanged.Mechanically rebind the two affected parser source proofs and aggregate context hash. Independent source and emitted-token comparison confirms exactly seven parser identifier substitutions plus formatting; all 31 proof identities, assumptions, replacements and outcomes remain unchanged.
Current head:
415ab9b92be1a85a732ea9a2466f38f424e32ab1, based on merged main3fed08fc9b21b580bacae2b136bb3b702833ce75. Tree:c936457aab0b7c672cc3ca0a50cb1eae3df0b175. The 16-file delta is +440/−130 lines, primarily tests. No documentation, dependency, workflow, parser algorithm, new production module or test-framework changes are introduced by this PR. The final main refresh adds only PR #52's upstream documentation; the reviewed code delta is byte-identical to the prepared integration.Local validation:
Required hosted verification passed: CI run 40618385544 completed successfully for this exact head. Required All checks and Conventional Commit PR title passed from GitHub Actions app 15368. Cold routing, discovery, all eleven parser partitions and the complete evidence collector passed. Main freshness was rechecked at
3fed08fc9b21b580bacae2b136bb3b702833ce75; the tested synthetic merge has the reviewed head's tree.Source review and required CI are complete. After authenticated owner authorization resolved the ready-transition approval block, this PR was squash-merged as
0cea08d0e3d6bd96155badacc9cdb21ad262d5c6. The merged treec936457aab0b7c672cc3ca0a50cb1eae3df0b175is identical to the reviewed and tested tree.