Skip to content

refactor: clarify parser mode and stabilize test seams - #54

Merged
choskeli merged 6 commits into
mainfrom
refactor/focused-clarity-fixes
Oct 28, 2026
Merged

choskeli merged 6 commits into
mainfrom
refactor/focused-clarity-fixes

Conversation

@choskeli

@choskeli choskeli commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Several tests depended on private callback names, exact YAML indentation, or comments and logging in the mutation runner. Replace those accidental dependencies with captured listener references, parsed YAML step selection, and bounded AST selection of complete runner policy spans. Regressions retain intervening statements, execute an extra promotion between guards, reject preceding/trailing/nested out-of-span promotions, tolerate formatting/logging changes, and detect a deliberately reattached renamed listener.

The selector accepts the labeled outer try introduced by PR #56. Its admission span includes and executes routingIdentity; the new fixture checks its value and initialization-before-read order. Deliberately omitting that initialization fails the fixture. The contiguous spans, recursive promotion-bounds check and PR #56 diagnostic assertions are preserved.

Clarify three private names: the parser's capacityRequired flag becomes successorEvidenceOnly, and the mutation helpers become runFreshShardCampaign and assertCurrentShardTests. Replace the misleading whole-parser scope error with “Mutation scope differs from expected scope,” which also describes shard/range mismatches accurately. Scope comparison, validation order, cache trust and mutation semantics are unchanged.

Mechanically rebind the two affected parser source proofs and aggregate context hash. Independent source and emitted-token comparison confirms exactly seven parser identifier substitutions plus formatting; all 31 proof identities, assumptions, replacements and outcomes remain unchanged.

Current head: 415ab9b92be1a85a732ea9a2466f38f424e32ab1, based on merged main 3fed08fc9b21b580bacae2b136bb3b702833ce75. Tree: c936457aab0b7c672cc3ca0a50cb1eae3df0b175. The 16-file delta is +440/−130 lines, primarily tests. No documentation, dependency, workflow, parser algorithm, new production module or test-framework changes are introduced by this PR. The final main refresh adds only PR #52's upstream documentation; the reviewed code delta is byte-identical to the prepared integration.

Local validation:

  • Final head: 283 focused policy, partition, shard, routing, workflow and complexity tests passed; all ten cache-policy fragment tests passed. Formatting, lint, current/legacy TypeScript and whitespace checks passed.
  • Before the documentation-only refresh, build and all 31 source-bound proof checks passed on the identical code. Complete cache suite: 17 passed and one Windows executable-mode assertion failed; the same unchanged assertion reproduced on main. No assertion was weakened or skipped.
  • The diagnostic regression suite demonstrated seven failures with the old misleading wording and seven passes with the corrected diagnostic.
  • The original parser/listener/YAML changes retain their prior focused validation. The previous published head passed hosted runtime, tooling and fresh parser mutation checks, but those results do not substitute for the new head's checks.
  • Independent review of the combined delta and final preservation check found no remaining findings. The parent independently cleared this published final head, including all 31 proof bindings, token-only parser/helper changes, the diagnostic and all ten fragment tests; the prior P2 finding remains closed. No extra local full exploratory mutation campaign was launched.

Required hosted verification passed: CI run 40618385544 completed successfully for this exact head. Required All checks and Conventional Commit PR title passed from GitHub Actions app 15368. Cold routing, discovery, all eleven parser partitions and the complete evidence collector passed. Main freshness was rechecked at 3fed08fc9b21b580bacae2b136bb3b702833ce75; the tested synthetic merge has the reviewed head's tree.

Source review and required CI are complete. After authenticated owner authorization resolved the ready-transition approval block, this PR was squash-merged as 0cea08d0e3d6bd96155badacc9cdb21ad262d5c6. The merged tree c936457aab0b7c672cc3ca0a50cb1eae3df0b175 is identical to the reviewed and tested tree.

@choskeli
choskeli marked this pull request as ready for review October 28, 2026 02:21
@choskeli
choskeli merged commit 0cea08d into main Oct 28, 2026
41 checks passed
@choskeli
choskeli deleted the refactor/focused-clarity-fixes branch October 28, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant