Repository navigation
fix: exclude out-of-range free-format candidates - #57
Merged
Merged
Conversation
# Conflicts: # AGENTS.md # docs/specifications/assessment-scope.md # docs/specifications/conformance.md # docs/specifications/input-classification.md
# Conflicts: # docs/specifications/assessment-scope.md # docs/specifications/conformance.md # docs/specifications/input-classification.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ancillary bytes in a valid 300 kb/s free-format stream could create a competing 480 kb/s interpretation and make the parser reject the file. Apply a per-sample-rate 320 kb/s envelope before candidates contribute framing evidence: maximum unpadded spans are 1044/960/1440 bytes at 44.1/48/32 kHz, and physical spans are limited to 1045/960/1440 bytes. Check every followed frame and every later locked span. Keep the fixed 8647-byte probe budget and existing ambiguity policy.
The inclusive 320 kb/s endpoint is the documented, reasoned interpretation of detailed header semantics; this does not claim that ISO/IEC 11172-3:1993 sections 2.1.67 and 2.4.2.3 use perfectly consistent wording. Section 2.4.3.4.4 and ITU-R BS.1115-1 Appendix 2 support the Layer III maximum. No table-derived minimum or guessed padding schedule is introduced. At 32/48 kHz the maximum base cannot add padding; at 44.1 kHz it can.
Genuine 400 kb/s LAME fixtures remain rejection controls, including packaged-runtime smoke. Genuine 128/192/320 kb/s fixtures retain their positive counts. Tests and independent construction oracles cover sample rates, channels, CRC, padding, short streams, transitions, upper/first-excluded spans, raw/multipart uploads and count options. Two ambiguity controls now use genuinely in-range competing layouts. Production changes remain in free-format.ts and frame-spans.ts.
Current head: 3288542, integrated once with post-revert main 68cb260. Independent integration source review is clear: parser, tests, fuzz inputs and all 31 proof bindings are identical to the previously reviewed head; only four cache files came from main. The original assignment is unchanged.
Current-head hosted checks are pending. Local integration checks passed 1798 parser tests (one existing optional skip), 48 API tests, build and 43 corpus replay executions. Cache/policy tests passed 180/181; the unchanged executable-mode assertion fails on Windows because chmod does not change its file mode. No assertion or skip was changed. The prior exact-head evidence below is historical, not certification of the new integration.
Independent source/spec and integration reviews are clear; normal protected merge awaits current-head required checks. #58 contains the separate short-frame correction. Indexed maximum-rate padding, same-rate indexed/free switching and broader ambiguity policies remain separate follow-ups. No CI/queue changes are included.