Repository navigation
fix: ignore dead-end ancillary headers in short free-format streams - #58
Merged
Merged
Conversation
choskeli
force-pushed
the
fix/short-free-format-dead-end
branch
from
October 28, 2026 04:08
90e39b0 to
d383a0b
Compare
choskeli
marked this pull request as ready for review
October 28, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A complete 864-byte free-format frame at 48 kHz was rejected when an ancillary header at byte 100 could not form a complete alternative. Reconsider EOF-closed one-/two-frame layouts only when ordinary root selection found no candidate and the probe contains one free-format configuration. Alternate headers contribute veto evidence only through complete walks whose every frame passes the existing necessary prefix, side-information and main-data capacity checks.
This also fixes the independently reviewed complete-but-impossible alternative: headers at 0/100/432 with byte 442 set to 0x10 must retain the valid singleton because the 432-byte interpretation has invalid side fields. The analogous two-frame stream with a supported footer-bearing ID3 tag is covered. Exact-capacity and genuine crossing alternatives remain protected.
Current head: d383a0b, directly based on merged #57 at 2e4b81c. Only the reviewed ten-file short-frame delta was replayed onto actual main. Parser, tests, fuzz inputs and all 32 proof bindings are identical to reviewed head 90e39b0; the only differences from that reviewed tree are four incoming cache files from main. No CI/queue or counting-default changes.
Each candidate is followed once. The fallback retains at most two frame records per deferred candidate and builds one bounded cumulative array at the root. Failed suffixes do not allocate fallback arrays. Existing successful selections, ties, three-header inference, plausible metadata and indexed/changed-rate/suffix policies retain their behavior. These are necessary validity checks, not audio decoding or a universal uniqueness rule. Indexed maximum-rate padding and broader ambiguity policies remain separate follow-ups.
Current integration validation: 1872 parser/API tests passed with one existing optional skip, 162 policy tests passed, build and 43 corpus replays passed. Independent integration source review is clear. Current-head CI run 40630646271 passed all 34 jobs, including the complete fresh parser audit: 1360 mutants, 100% adjusted. Both required app-bound checks passed; the tested merge tree exactly equals reviewed tree
21947c48835e48a4490fe331a09acab912a2d41e. Historical exact-head evidence below applies to reviewed head 90e39b0, not the new integration:< length→<= lengthmutation: it adds only an ignored out-of-range typed-array write. The source-bound proof is explicit in mutation-equivalents.json and docs/mutation-review.md. Neither the meaningful marker shift nor the per-suffix allocation mutation is exempted.Merged normally after independent review and all current-head required checks at e8b2dd3. No release publication.