Skip to content

test(p0): pin facet custody args_prefix with --no-subprocess - #119

Closed
VirtualMachinist wants to merge 1 commit into
mainfrom
feat/facet-no-subprocess-pin
Closed

VirtualMachinist wants to merge 1 commit into
mainfrom
feat/facet-no-subprocess-pin

Conversation

@VirtualMachinist

@VirtualMachinist VirtualMachinist commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Pin the Facet custody run with --no-subprocess.

Facet 0.8.0 adds --no-subprocess on request run. With it, Facet starts no gh or git child: no gh auth token, no gh api fallback and no git: tag. Under a Geode binding that is the control for Facet's child processes. Facet does not sha256-pin gh itself, because Homebrew changes its bytes on every upgrade. From the 0.8.0 custody re-pin on, the P0 FACET_SECRET_KEY custody argv requires it.

  • crates/geode-cli/tests/fixtures/p0-facet-secret-key.args: args_prefix is now ["request","run","--no-record","--no-subprocess"]. The path and sha stay placeholders.
  • crates/geode-cli/tests/p0_custody_home.rs: PREFIX has four items. each_broken_rule_fails now fails the prefix rule when --no-subprocess is dropped, when --no-record is dropped, and when only request run is left.
  • CHANGELOG.md: one Unreleased / Changed line.

Tests and the changelog only. No product source, dependency or version change.

The live custody allowlist is not part of this PR. Its matching one-line change (args_prefix gains --no-subprocess) is staged separately for its owner to install. Against Geode 3.0.0 and the pinned Facet 0.8.0, the staged allowlist accepts request run --no-record --no-subprocess … and refuses request run --no-record … with does not match its allow_cmds args_prefix. args_prefix is ordered, so --no-subprocess --no-record is refused too.

Gates on the head: cargo fmt --check, cargo clippy --workspace --all-targets --locked -- -D warnings, and nextest (620 passed, 3 skipped).

Draft until this exact head is cleared.

🤖 Generated with Claude Code

Facet 0.8.0 is the castle custody binary. The P0 FACET_SECRET_KEY argv
fixture now pins args_prefix ["request","run","--no-record",
"--no-subprocess"], and the lint's PREFIX is the 4-item array.
each_broken_rule_fails gains cases that drop --no-subprocess and that
drop --no-record, and keeps the 2-item case. Tests, fixture and
CHANGELOG only; no product src.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@VirtualMachinist

Copy link
Copy Markdown
Member Author

Superseded by #120: the same change as one clean commit, plus a reordered-prefix test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant