Repository navigation
test(p0): pin facet custody args_prefix with --no-subprocess - #119
Closed
VirtualMachinist wants to merge 1 commit into
Closed
VirtualMachinist wants to merge 1 commit into
VirtualMachinist wants to merge 1 commit into
Conversation
Facet 0.8.0 is the castle custody binary. The P0 FACET_SECRET_KEY argv fixture now pins args_prefix ["request","run","--no-record", "--no-subprocess"], and the lint's PREFIX is the 4-item array. each_broken_rule_fails gains cases that drop --no-subprocess and that drop --no-record, and keeps the 2-item case. Tests, fixture and CHANGELOG only; no product src. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Superseded by #120: the same change as one clean commit, plus a reordered-prefix test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the Facet custody run with
--no-subprocess.Facet 0.8.0 adds
--no-subprocessonrequest run. With it, Facet starts noghorgitchild: nogh auth token, nogh apifallback and nogit:tag. Under a Geode binding that is the control for Facet's child processes. Facet does not sha256-pinghitself, because Homebrew changes its bytes on every upgrade. From the 0.8.0 custody re-pin on, the P0FACET_SECRET_KEYcustody argv requires it.crates/geode-cli/tests/fixtures/p0-facet-secret-key.args:args_prefixis now["request","run","--no-record","--no-subprocess"]. The path and sha stay placeholders.crates/geode-cli/tests/p0_custody_home.rs:PREFIXhas four items.each_broken_rule_failsnow fails the prefix rule when--no-subprocessis dropped, when--no-recordis dropped, and when onlyrequest runis left.CHANGELOG.md: oneUnreleased/Changedline.Tests and the changelog only. No product source, dependency or version change.
The live custody allowlist is not part of this PR. Its matching one-line change (
args_prefixgains--no-subprocess) is staged separately for its owner to install. Against Geode 3.0.0 and the pinned Facet 0.8.0, the staged allowlist acceptsrequest run --no-record --no-subprocess …and refusesrequest run --no-record …withdoes not match its allow_cmds args_prefix.args_prefixis ordered, so--no-subprocess --no-recordis refused too.Gates on the head:
cargo fmt --check,cargo clippy --workspace --all-targets --locked -- -D warnings, and nextest (620 passed, 3 skipped).Draft until this exact head is cleared.
🤖 Generated with Claude Code