Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ Format: [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). Versioning: se

## [Unreleased]

### Changed

- The P0 `FACET_SECRET_KEY` custody argv pins Facet 0.8.0 with `args_prefix` `["request","run","--no-record","--no-subprocess"]`, so a pinned `facet` run cannot start `gh` or `git`. The fixture lint fails when `--no-subprocess` is missing.

### Fixed

- An identity added with `vault add-recipient --gpub` (or `vault rotate --add-recipient`) can now open its vault: `verify`, `list`, `cat`, `open` and `rotate` unwrap the epoch key from the identity's X25519 recipient entry. Before, only symmetric recipients were matched and the added key failed with an authentication error.
Expand Down
2 changes: 1 addition & 1 deletion crates/geode-cli/tests/fixtures/p0-facet-secret-key.args
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
--allow-host
api.example.test
--allow-cmd
{"path":"/usr/local/libexec/hedronite/facet","sha256":"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa","args_prefix":["request","run","--no-record"]}
{"path":"/usr/local/libexec/hedronite/facet","sha256":"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa","args_prefix":["request","run","--no-record","--no-subprocess"]}
--secret
FACET_SECRET_KEY=cfg/facet-secret-key
14 changes: 12 additions & 2 deletions crates/geode-cli/tests/p0_custody_home.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use std::collections::BTreeSet;
use std::path::{Component, Path, PathBuf};

const FIXTURE: &str = "tests/fixtures/p0-facet-secret-key.args";
const PREFIX: [&str; 3] = ["request", "run", "--no-record"];
const PREFIX: [&str; 4] = ["request", "run", "--no-record", "--no-subprocess"];

fn raw() -> String {
let path = PathBuf::from(env!("CARGO_MANIFEST_DIR")).join(FIXTURE);
Expand Down Expand Up @@ -206,7 +206,7 @@ fn each_broken_rule_fails() {
("allow-host", "--allow-host\napi.example.test\n", ""),
(
"allow-cmd-json",
"{\"path\":\"/usr/local/libexec/hedronite/facet\",\"sha256\":\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\",\"args_prefix\":[\"request\",\"run\",\"--no-record\"]}",
"{\"path\":\"/usr/local/libexec/hedronite/facet\",\"sha256\":\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\",\"args_prefix\":[\"request\",\"run\",\"--no-record\",\"--no-subprocess\"]}",
"/usr/local/libexec/hedronite/facet",
),
(
Expand All @@ -216,7 +216,17 @@ fn each_broken_rule_fails() {
),
(
"allow-cmd-prefix",
"\"args_prefix\":[\"request\",\"run\",\"--no-record\",\"--no-subprocess\"]",
"\"args_prefix\":[\"request\",\"run\",\"--no-record\"]",
),
(
"allow-cmd-prefix",
"\"args_prefix\":[\"request\",\"run\",\"--no-record\",\"--no-subprocess\"]",
"\"args_prefix\":[\"request\",\"run\",\"--no-subprocess\"]",
),
(
"allow-cmd-prefix",
"\"args_prefix\":[\"request\",\"run\",\"--no-record\",\"--no-subprocess\"]",
"\"args_prefix\":[\"request\",\"run\"]",
),
(
Expand Down
Loading