Skip to content

test(p0): pin facet custody args_prefix with --no-subprocess - #120

Merged
VirtualMachinist merged 1 commit into
mainfrom
feat/facet-no-subprocess-pin-v2
Oct 31, 2026
Merged

VirtualMachinist merged 1 commit into
mainfrom
feat/facet-no-subprocess-pin-v2

Conversation

@VirtualMachinist

Copy link
Copy Markdown
Member

Pin the Facet custody run with --no-subprocess. This replaces #119 with the same change as one clean commit, plus one more test case.

Facet 0.8.0 adds --no-subprocess on request run. With it, Facet starts no gh or git child: no gh auth token, no gh api fallback and no git: tag. Under a Geode binding, that flag is what controls Facet's child processes. Facet does not sha256-pin gh itself, because Homebrew changes its bytes on every upgrade. From the 0.8.0 custody re-pin on, the P0 FACET_SECRET_KEY custody argv requires the flag.

  • crates/geode-cli/tests/fixtures/p0-facet-secret-key.args: args_prefix is now ["request","run","--no-record","--no-subprocess"]. The path and sha stay placeholders.
  • crates/geode-cli/tests/p0_custody_home.rs: PREFIX has four items. each_broken_rule_fails now fails the prefix rule in four cases:
  • CHANGELOG.md: one Unreleased / Changed line.

The PR touches tests and the changelog only. No product source, dependency or version change.

The live custody allowlist is not part of this PR. Its matching one-line change (args_prefix gains --no-subprocess) is staged separately for its owner to install. Against Geode 3.0.0 and the pinned Facet 0.8.0, the staged allowlist accepts request run --no-record --no-subprocess … and refuses both request run --no-record … and request run --no-subprocess --no-record … with does not match its allow_cmds args_prefix.

Gates on the head: cargo fmt --all -- --check, cargo clippy --workspace --all-targets --locked -- -D warnings, and nextest (620 passed, 3 skipped).

Draft until this exact head is cleared.

🤖 Generated with Claude Code

The P0 FACET_SECRET_KEY argv fixture pins args_prefix ["request","run","--no-record","--no-subprocess"] for Facet 0.8.0, and the lint PREFIX is the 4-item array. each_broken_rule_fails fails the prefix rule when --no-subprocess is dropped, when --no-record is dropped, when the two flags are swapped, and when only request run is left. Tests, fixture and CHANGELOG only; no product src.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@VirtualMachinist
VirtualMachinist marked this pull request as ready for review October 31, 2026 10:54
@VirtualMachinist
VirtualMachinist merged commit a608631 into main Oct 31, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant