Repository navigation
Show pad names in the viewer (#96) - #104
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FzHC7LspikUyimHw5ptN8x
|
Owner
Author
|
PR review, round 1 (code-review skill + manual check of escaping, label sites, Allegro fallback, table order). Findings:
Checked, no finding: pad table uses |
padName() takes a pad name only when it is a string, as mcp/src/pads.js does, so the viewer and the tools agree on which pads have a pin name. Tooltip and pad table both use it. Fix the pad table comment: it does not match the tooltip for an unnamed pin-1 pad. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FzHC7LspikUyimHw5ptN8x
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96. Part of #73.
When the export has a pad name, the viewer shows it. On netdaq, U24's third pad now reads
pin 11 — GNDin the tooltip, notpad 3. Boards without names (stock ibom, Allegro, the ciaa-acc fixture) still showpin 1/pad N.Wording:
pin <name>. The name is the pin as the netlist calls it (REFDES:PIN), and the MCP tools return it aspin, so the viewer and the agent use the same word. An exposed pad namedEPreadspin EP. That matches what the netlist and the tools call it (U24:EP), so I kept it. An empty name (KiCad NPTH holes) falls back topad N.Where labels show:
padLabelinweb/render.js, used bypadHitScan).#column of the detail pane's pad table (web/app.js). It shows the name, or the place in the list when there is none.The pad search and net lists show no pad labels, so nothing else changes.
Payload: no change needed.
make_pcb_payloadcopiespcbdataas is, sonamereaches the page. The new test reads it from the built page.The tooltip now escapes its text. Ref, value, net and pad name went into
innerHTMLas they were.Tests:
tests/browser/pad-names.spec.js: hover on the named board (U24 pin 11 and pin 1, plus the pad table), hover on ciaa-acc (U46 showspad 4, pad table 1..N), and a name with markup shows as text. The named-board and markup tests fail onagent-mcpwithout this change.cull.spec.jszoomed render,interaction.spec.jsinner layer checkbox). Both were load timeouts while the MCP tests ran Chromium at the same time. Both passed when run again on their own (47 passed). Perf counter tests passed.mcpnpm test: http 105 passed, stdio 103 passed, 2 skipped (HTTP only).tools/smoke_test_api.js: ALL OK.🤖 Generated with Claude Code
https://claude.ai/code/session_01FzHC7LspikUyimHw5ptN8x