Skip to content

Pad table: head the first column Pin (#96 follow-up) - #106

Merged
Gherkin merged 2 commits into
agent-mcpfrom
pad-pin-header
Oct 11, 2026
Merged

Gherkin merged 2 commits into
agent-mcpfrom
pad-pin-header

Conversation

@Gherkin

@Gherkin Gherkin commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Follow-up to #96.

The pad table's first column shows pin names ("A1", "EP", "11") since #104. Its header was still "#", which reads as a count. It now says "Pin", to match the "pin 11" tooltip and the netlist's REFDES:PIN.

Unnamed pads still show their place in the list. No change there.

  • web/app.js: header text.
  • tests/browser/pad-names.spec.js: the named-board test now checks the headers are Pin, Net, Type.

Tests: Playwright 105 passed, 1 failed (interaction.spec.js:739, the known flake). That test passed when run alone.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FzHC7LspikUyimHw5ptN8x

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FzHC7LspikUyimHw5ptN8x
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-11 17:40 UTC

@Gherkin

Gherkin commented Oct 11, 2026

Copy link
Copy Markdown
Owner Author

/prr round 1 (code-review run). 4 findings, all checked against the code.

  1. web/app.js:983 - header is "Pin" even on unnamed boards, where the column shows list places. Not fixed: the user chose "Pin" there too (last comment on Show pad names in the viewer #96).
  2. tests/browser/pad-names.spec.js:80 - unnamed-board test did not check the header. Fixed: it now asserts ['Pin', 'Net', 'Type'] on ciaa-acc.

FYI (older than this PR, out of scope):
3. web/app.js:995 - fallback is per pad; in a footprint with some named pads, an unnamed pad's list place can match a real pin name.
4. web/app.js:995 vs web/render.js:1078 - an unnamed pin1 pad shows "pin 1" in the tooltip but i+1 in the table.

No other place labels that column (CSS, aria, README checked).

@Gherkin
Gherkin merged commit 4fffb84 into agent-mcp Oct 11, 2026
10 checks passed
@Gherkin
Gherkin deleted the pad-pin-header branch October 11, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant