Skip to content

[nodejs] Inferred Proxy Spans - tests for endpoint discovery and correlation with appsec#5935

Merged
simon-id merged 13 commits intomainfrom
ccapell/APPSEC-60015/node-js-inferred-proxy-spans-updates
Mar 12, 2026
Merged

[nodejs] Inferred Proxy Spans - tests for endpoint discovery and correlation with appsec#5935
simon-id merged 13 commits intomainfrom
ccapell/APPSEC-60015/node-js-inferred-proxy-spans-updates

Conversation

@CarlesDD
Copy link
Contributor

@CarlesDD CarlesDD commented Jan 5, 2026 •
edited by atlassian bot
Loading

Motivation

Test the changes related to RFC-1081: Endpoint discovery and correlation from Inferred spans.

Changes

Enable test on Node.js manifest.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

APPSEC-60015

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026 •
edited
Loading

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/integrations/test_inferred_proxy.py                               @DataDog/system-tests-core

@CarlesDD CarlesDD mentioned this pull request Jan 5, 2026
Merged
@CarlesDD CarlesDD force-pushed the ccapell/APPSEC-60015/node-js-inferred-proxy-spans-updates branch from b5f06ec to 49cabc5 Compare January 21, 2026 21:07
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 21, 2026 •
edited by datadog-prod-us1-4 bot
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9505049 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@CarlesDD CarlesDD self-assigned this Jan 22, 2026
@CarlesDD CarlesDD force-pushed the ccapell/APPSEC-60015/node-js-inferred-proxy-spans-updates branch from 6e3d57a to 111a8d3 Compare January 22, 2026 11:36
@CarlesDD CarlesDD changed the title [nodejs@ccapell/APPSEC-60015/inferred-proxy-spans] Inferred Proxy Spans - tests for endpoint discovery and correlation with appsec [nodejs] Inferred Proxy Spans - tests for endpoint discovery and correlation with appsec Jan 22, 2026
@CarlesDD CarlesDD changed the title [nodejs] Inferred Proxy Spans - tests for endpoint discovery and correlation with appsec [nodejs@ccapell/APPSEC-60015/inferred-proxy-spans] Inferred Proxy Spans - tests for endpoint discovery and correlation with appsec Jan 22, 2026
@CarlesDD CarlesDD force-pushed the ccapell/APPSEC-60015/node-js-inferred-proxy-spans-updates branch from 40bb280 to 845d0ac Compare March 11, 2026 06:37
@CarlesDD CarlesDD changed the title [nodejs@ccapell/APPSEC-60015/inferred-proxy-spans] Inferred Proxy Spans - tests for endpoint discovery and correlation with appsec [nodejs] Inferred Proxy Spans - tests for endpoint discovery and correlation with appsec Mar 11, 2026
@CarlesDD CarlesDD marked this pull request as ready for review March 11, 2026 19:24
@CarlesDD CarlesDD requested review from a team as code owners March 11, 2026 19:24
@CarlesDD CarlesDD enabled auto-merge (squash) March 11, 2026 19:25
simon-id
simon-id reviewed Mar 11, 2026
View reviewed changes
manifests/nodejs.yml Outdated
tests/integrations/test_inferred_proxy.py::Test_AWS_API_Gateway_Inferred_Span_Creation_v2: missing_feature
tests/integrations/test_inferred_proxy.py::Test_AWS_API_Gateway_Inferred_Span_Creation_v2:
- weblog_declaration:
"*": irrelevant
Copy link
Member

@simon-id simon-id Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why irrelevent isntead of missing feat ?

Copy link
Contributor Author

@CarlesDD CarlesDD Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the tested feature is framework-agnostic, works on all variants, but testing additional variants provides no extra coverage here

Copy link
Member

@simon-id simon-id Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I've done that too for another test, and i added a comment # one weblog is enough coverage or something, wdyt ?

Copy link
Contributor Author

@CarlesDD CarlesDD Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@CarlesDD CarlesDD disabled auto-merge March 12, 2026 08:21
@simon-id simon-id enabled auto-merge (squash) March 12, 2026 10:31
@simon-id simon-id merged commit b17af66 into main Mar 12, 2026
435 checks passed
@simon-id simon-id deleted the ccapell/APPSEC-60015/node-js-inferred-proxy-spans-updates branch March 12, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IlyasShabi IlyasShabi IlyasShabi approved these changes

@simon-id simon-id simon-id approved these changes

Assignees

@CarlesDD CarlesDD

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlesDD @IlyasShabi @simon-id