feat(aap): update tags for inferred proxy spans#7171
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.93 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7171 +/- ##
=======================================
Coverage 80.31% 80.32%
=======================================
Files 739 739
Lines 31946 31966 +20
=======================================
+ Hits 25658 25677 +19
- Misses 6288 6289 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
CarlesDD
force-pushed
the
ccapell/APPSEC-60015/inferred-proxy-spans
branch
from
9e59dbf to
3136e80
Compare
BenchmarksBenchmark execution time: 2026-03-06 05:14:11 Comparing candidate commit dabfdea in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 231 metrics, 29 unstable metrics. |
CarlesDD
force-pushed
the
ccapell/APPSEC-60015/inferred-proxy-spans
branch
from
ca120f8 to
ed4e018
Compare
uurien
reviewed
Feb 5, 2026
zarirhamza
previously approved these changes
Feb 5, 2026
Contributor
zarirhamza
left a comment
zarirhamza
left a comment
There was a problem hiding this comment.
The changes are all sufficient aside from the performance improvements mentioned before.
However, to get CI working, it seems that system-tests need to be updated to account for the new https string prefixed to the URLs. Until this change is rolled out to the other languages as well, we should avoiding changing the test entirely and just create a separate use case specific for JS to include the https prefix.
simon-id
reviewed
Feb 17, 2026
simon-id
reviewed
Feb 17, 2026
simon-id
reviewed
Feb 17, 2026
simon-id
reviewed
Feb 17, 2026
simon-id
reviewed
Feb 17, 2026
Member
|
Otherwise LGTM, but the inferred spans code is not ours so should we have an approval from the owners of that code ? |
CarlesDD
force-pushed
the
ccapell/APPSEC-60015/inferred-proxy-spans
branch
from
0c7e2e6 to
bcefecb
Compare
simon-id
reviewed
Mar 9, 2026
simon-id
approved these changes
Mar 9, 2026
Member
simon-id
left a comment
simon-id
left a comment
There was a problem hiding this comment.
LGTM, but as i wrote before, maybe worth a little eye from whoever owns the inferred proxy code ? up to you
gh-worker-ownership-write-b05516
bot
removed request for
a team and
jchrostek-dd
Contributor
Author
@zarirhamza already reviewed this earlier, but I’m tagging them here again to get their final approval and make sure we close the loop on the inferred proxy part. |
wconti27
approved these changes
Mar 10, 2026
Contributor
wconti27
left a comment
wconti27
left a comment
There was a problem hiding this comment.
LGTM, good catches by Simon's previous review, they answered a lot of the questions I had about the change!
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
API Gateway v2 (HTTP API) support: Added
aws-httpapito the supported proxies map, generating spans with nameaws.httpapi(in addition to existingaws.apigatewayfor REST API v1).Span attributes improvements:
serverto inferred proxy spanshttps://schemex-dd-proxy-resource-pathheader to populate http.route tagx-dd-proxy-resource-path) when available, falling back to the pathAppSec integration:
_dd.appsec.enabled: 1metric to inferred proxy spans when AppSec is enabledAdditional span tags (when corresponding headers are present):
account_idfromx-dd-proxy-account-idapiidfromx-dd-proxy-api-idregionfromx-dd-proxy-regionaws_userfromx-dd-proxy-userdd_resource_keycomputed as API Gateway ARN:arn:aws:apigateway:{region}::/restapis/{api-id}arn:aws:apigateway:{region}::/apis/{api-id}Motivation
Implementation of RFC-1081 on Endpoint Discovery & Correlation from API Gateway Inferred Spans, summary of changes:
Additional Notes
APPSEC-60015
System test: DataDog/system-tests#6245
System test: DataDog/system-tests#5935