feat(observability): export readiness evidence gauges - #142
Conversation
📝 WalkthroughWalkthrough
Changes운영 준비성 지표
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The new readiness metric may describe readonly-auth configurations inaccurately by labeling the absence of write-capable credentials as disabled authentication. This is a bounded monitoring/documentation risk and is mergeable with explicit owner awareness or a follow-up correction. Sequence Diagram(s)sequenceDiagram
participant MetricsHandler
participant operational_prometheus_exposition
participant PrometheusResponse
MetricsHandler->>operational_prometheus_exposition: state, data, timestamp 전달
operational_prometheus_exposition->>PrometheusResponse: KPI 및 운영 준비성 게이지 추가
PrometheusResponse-->>MetricsHandler: Prometheus text 반환
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai autofix |
|
@coderabbitai autofix |
|
Autofix skipped. No unresolved review comments with fix instructions found. |
|
@coderabbitai Please fix the current Devin finding on this PR and commit the fix directly to the current |
|
Failed to start a Devin session. Please try again. |
|
Failed to start a Devin session. Please try again. |
|
Failed to start a Devin session. Please try again. |
| fn operational_prometheus_exposition(state: &AppState, data: &AppData, now_unix: u64) -> String { | ||
| let kpis = kpi_snapshot_at(data, now_unix); | ||
| let readiness = commercial_readiness_snapshot_at(data, now_unix); | ||
| let routes_enabled = data.routes.iter().filter(|route| route.enabled).count(); |
There was a problem hiding this comment.
📝 Info: Readiness gauges preserve endpoint semantics
Both route gauges use the same enabled-route predicate as readyz. One state snapshot keeps their values mutually consistent.
Was this helpful? React with 👍 or 👎 to provide feedback.
Superseded by clean-base replacement #152
This observability slice remains valid, but the old branch diverged from the final reviewed runner prerequisite: its ancestry stopped at predecessor runner head
2d41c4079f9a4465c3142a0aa2dd5895cb11f793, while clean runner replacement #149 now owns exact headb663f9d200e5f385c7dd067d074940a02836c68e.Replacement #152 reconstructs the reviewed semantic head
e7ef34d9f2c5d31873d7c09889b302279e8a4162on top of exact clean #149 via non-destructive merge commit387a447f856093d02116dfadcf2c4a4a63c6d3ba. A fresh comparison againstb663f9d…reportsbehind_by=0; the effective delta remains exactly the four observability files and preserves the repaired HELP-text/admin-auth semantics.No predecessor check/review evidence transfers across PR identity. Close this stale-base PR and continue validation/integration through #152.