fix(ops): restore bundled Zipkin tracing transport - #167
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #166 test-first. Protected
develop@622e5e6c3d534f230c390f10e3832efadfc01825bundledopenzipkin/zipkin:2as if its HTTP collector listened on container port 9412. The upstream image documents port 9411, while ETL, CDC, and gateway targetedzipkin:9412, so the default distributed-tracing transport was not defensible.Status:
active_pr; this is not shipped truth until protected integration.Exact candidate
develop@622e5e6c3d534f230c390f10e3832efadfc0182582228115235edffbb37ef3fb662d60acf84ddb6e8bf04b1a57e4c74d49bf880a52c2b16c7276f7f0, then smallest GREEN production correction82228115235edffbb37ef3fb662d60acf84ddb6e.docker-compose.ymlplusDockerComposeZipkinTransportTest.RED → GREEN evidence
The test-only head reached the intended shipped Compose boundary in hosted CI and failed because
9412:9411was absent. It was not an import/fixture/setup failure.The current candidate changes only the bundled Compose topology:
9412:9411);MANAGEMENT_ZIPKIN_TRACING_ENDPOINT=http://zipkin:9411/api/v2/spans;Current CI run
31336585539is GREEN on macOS, Windows, and Ubuntu. On macOS job93303341090,DockerComposeZipkinTransportTestran at the product topology boundary and passed; the full Maven reactor completed successfully. The workflow checked out GitHub synthetic mergea9169f87fad964952ac73d4dac914f7ad5e82aa0(Merge 8222811... into 622e5e6...), not literal source head, so this is useful merged-tree proof but is not promoted to literal-head acceptance evidence.Dependency Review
31336585553, CycloneDX SBOM31336585533, and SAST Semgrep31336585566are GREEN on the current PR event.Current non-passing gate RCA
Security Scan
31336585531is FAILED solely in Trivy filesystem job93303341065. The scan completed successfully and reported the six already-known protected-base Jackson findings inetl-service/pom.xml/ root dependency resolution: CVE-2026-54515, CVE-2026-59889, and GHSA-mhm7-754m-9p8w. This PR changes no Maven dependency or Java production source. Shared remediation is already owned by PR #160; duplicating that POM change here or weakening/suppressing Trivy would create competing work rather than fix the root cause.Classification:
defer_until_triggerfor this exact security gate until #160 integrates (or protecteddevelopotherwise contains the accepted Jackson remediation), then rebase-free revalidation/replacement from the new protected base must regenerate evidence. Stacking this PR on #160 is also rejected while #160 has not satisfied progression governance.Separately, protected-base JaCoCo still logs
Analyzed bundle 'etl-service' with 0 classes; #162/#164 own the non-vacuous coverage control. This YAML/test-only slice does not claim that the inherited vacuous gate is acquisition-grade coverage evidence.Review / merge boundary
CodeRabbit skipped review because this PR remains Draft. No qualifying formal approval exists. Do not mark ready/merge merely because functional CI is green: Security Scan is genuinely non-passing, literal-source execution controls remain separate, the inherited coverage gate is not acceptable evidence, and old-head/base checks or reviews do not transfer.
No secret, fake collector, tracing disablement, security suppression, gate weakening, cross-repository write, force push, or destructive history rewrite is used.