test(security): prove local Compose ports are loopback-bound - #279
Closed
seonghobae wants to merge 1 commit into
Closed
test(security): prove local Compose ports are loopback-bound#279seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Test-first security work for #180 from exact protected parent
develop@942d164ceb7af497bb28a95f842db96429d1bdc4.This Draft adds only
LocalComposeLoopbackBindingTest. It exercises the shipped rootdocker-compose.ymland requires every published host port in the default local profile to be explicitly bound to127.0.0.1. Protecteddevelopcurrently publishes all nine mappings without a host address, so the intended first hosted result is RED at that production deployment boundary.Writer / integration boundary
Active PR #167 currently owns
docker-compose.ymlfor the Zipkin transport repair. This branch therefore does not mutate Compose or attempt the GREEN production fix. Once #167 integrates/closes or yields a stable non-racing parent, #180 can apply the narrow loopback mappings and make this test GREEN.Exact identity
942d164ceb7af497bb28a95f842db96429d1bdc4;55add0bf01325e64b538cfee572278a9c42fa404;942d164ceb7af497bb28a95f842db96429d1bdc4;Acceptance boundary
The RED is valid only if hosted CI compiles the test and fails its loopback assertion against the actual bundled Compose file. Setup/import/path/fixture errors do not count. No passing check, review, or merge claim is made until exact-head evidence is refetched.
This test is a safer local-default control only. It does not claim that loopback binding substitutes for #161 service authentication, #185 registry identity, TLS, or a production deployment security profile.